Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get correct Flash mode via API #7178

Closed
wants to merge 3 commits into from

Conversation

Jason2866
Copy link
Collaborator

Flash Mode is not read from magic header.
Th PR includes #7159

Fixes #7140

@Jason2866
Copy link
Collaborator Author

Output of test sketch

I (41) spi_flash: detected chip: gd
I (50) spi_flash: flash io: qio
I (50) coexist: coexist rom version e7ae62f
I (50) cpu_start: Starting scheduleESP32 SDK: v4.4.3-167-ge53afc285c
ESP32 DEVICE: ESP32-S3
ESP32 CPU FREQ: 240 MHz
ESP32 XTAL FREQ: 40 MHz
ESP32 APB FREQ: 80.0 MHz
ESP32 FLASH SIZE: 8.00 MB
ESP32 FLASH MODE: QIO
ESP32 RAM SIZE: 400.06 KB
ESP32 FREE RAM: 376.41 KB
ESP32 MAX RAM ALLOC: 343.99 KB
ESP32 FREE PSRAM: 7139.33 KB

@me-no-dev
Copy link
Member

I think you have mixed the code from both PRs here. Please fix that. Also, why remove the enum and replace it with string? Please revert that and provide another method do get the string.

p.s. Question how that will behave on OPI stands here as well.

@Jason2866 Jason2866 closed this Aug 25, 2022
@Jason2866
Copy link
Collaborator Author

Jason2866 commented Aug 25, 2022

Will not open a new PR before #7159 is included in some way.
Can not test OPI, since no device.

@Jason2866 Jason2866 deleted the flash_mode branch August 25, 2022 09:51
@Jason2866 Jason2866 restored the flash_mode branch September 7, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flash mode is wrong identified with the API call
2 participants