Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/add jobid to name of logfiles #1106

Draft
wants to merge 1 commit into
base: release
Choose a base branch
from
Draft

feat/add jobid to name of logfiles #1106

wants to merge 1 commit into from

Conversation

nwieters
Copy link
Contributor

@nwieters nwieters commented Dec 14, 2023 •
edited
Loading

This PR will add the jobtype and jobid to the filename of all logfiles.

closes #842

@nwieters nwieters self-assigned this Dec 14, 2023
@nwieters nwieters linked an issue Dec 14, 2023 that may be closed by this pull request
all logfiles should contain the jobid in their filename #842
Open
@nwieters nwieters changed the title Added jobid to name of logfiles. feat/add jobid to name of logfiles Dec 15, 2023
@nwieters
Copy link
Contributor Author

I think the function initialize_experiment_logfile in compute.py is not used at all.

@nwieters
Copy link
Contributor Author

There will be now a run_test_issue_842_esm_runscripts_<cluster>_<drom_to>_<jobid>.log for each cluster.
I think before, they were always overwritten by the logfile creation (open file with w instead of a).

@mandresm
Copy link
Contributor

TODO

  • Decide if we really want this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandresm mandresm Awaiting requested review from mandresm

At least 1 approving review is required to merge this pull request.

Assignees

@nwieters nwieters

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

all logfiles should contain the jobid in their filename
2 participants
@nwieters @mandresm