Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all logfiles should contain the jobid in their filename #842

Open
chrisdane opened this issue Nov 8, 2022 · 2 comments · May be fixed by #1106
Open

all logfiles should contain the jobid in their filename #842

chrisdane opened this issue Nov 8, 2022 · 2 comments · May be fixed by #1106
Assignees

Comments

@chrisdane
Copy link
Contributor

Is your feature request related to a problem? Please describe.
In an awicm-1.0-recom simulation, 5 logfiles are created in the log/ directory per run:

<expid>_awicm_compute_<from>-<to>_<jobid>.log
<expid>_awicm_observe_compute_<from>-<to>.log
<expid>_awicm_prepcompute_<from>-<to>.log
<expid>_awicm_tidy_<from>-<to>.log
<expid>_esm_runscripts_<from>-<to>.log

Only one of them contains the jobid. If a specific date is computed more than once, the logfiles without the jobid in their filenames will be overwritten.

Describe the solution you'd like
All logfiles should contain the jobid in their filename.

Thanks and cheers,
Chris

@mandresm
Copy link
Contributor

mandresm commented Nov 8, 2022

Good catch. The good news is that the compute one contains all of them in one single file, so the information of the ones that are not stamped with the jobid is not lost.

@pgierz
Copy link
Member

pgierz commented Nov 8, 2022

If we are opening this part of the runscripts anyway, may I suggest for the PR to be able to fully customise this, but with sensible defaults as suggested? I would say job type, date, slurm ID (maybe also Process ID)

If someone wants to customise and put their logs into blah123 then so be it. I'm happy to look, but I will guess @mandresm alreafy has the relevant parts open in his vim.

@nwieters nwieters self-assigned this Dec 14, 2023
@nwieters nwieters linked a pull request Dec 14, 2023 that will close this issue
@nwieters nwieters linked a pull request Dec 14, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants