Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce devicecode login as it can be useful in special situations #179

Merged
merged 1 commit into from
Dec 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 45 additions & 4 deletions src/sumo/wrapper/_auth_provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,45 @@ def login(self):
pass


class AuthProviderDeviceCode(AuthProvider):
def __init__(self, client_id, authority, resource_id):
super().__init__(resource_id)
cache = get_token_cache(resource_id)
self._app = msal.PublicClientApplication(
client_id=client_id, authority=authority, token_cache=cache
)
self._resource_id = resource_id
self._scope = scope_for_resource(resource_id)
if self.get_token() is None:
self.login()
pass
return

def login(self):
flow = self._app.initiate_device_flow([self._scope])

if "error" in flow:
raise ValueError(
"Failed to create device flow. Err: %s"
% json.dumps(flow, indent=4)
)

print(flow["message"])
result = self._app.acquire_token_by_device_flow(flow)

if "error" in result:
raise ValueError(
"Failed to acquire token by device flow. Err: %s"
% json.dumps(result, indent=4)
)

protect_token_cache(self._resource_id)

return

pass


class AuthProviderManaged(AuthProvider):
def __init__(self, resource_id):
super().__init__(resource_id)
Expand All @@ -203,6 +242,7 @@ def get_auth_provider(
interactive=False,
access_token=None,
refresh_token=None,
devicecode=False,
):
if refresh_token:
return AuthProviderRefreshToken(
Expand All @@ -214,7 +254,11 @@ def get_auth_provider(
# ELSE
if interactive:
return AuthProviderInteractive(client_id, authority, resource_id)

# ELSE
if devicecode:
# Potential issues with device-code
# under Equinor compliant device policy
return AuthProviderDeviceCode(client_id, authority, resource_id)
# ELSE
if all(
[
Expand All @@ -228,8 +272,5 @@ def get_auth_provider(
]
):
return AuthProviderManaged(resource_id)

# ELSE
# Device code login does not work with Equinor compliant device policy
# return AuthProviderDeviceCode(client_id, authority, resource_id)
return AuthProviderInteractive(client_id, authority, resource_id)
13 changes: 12 additions & 1 deletion src/sumo/wrapper/login.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,15 @@ def get_parser() -> ArgumentParser:
help="Login interactively",
)

parser.add_argument(
"-d",
"--devicecode",
dest="devicecode",
action="store_true",
default=False,
help="Login with device-code",
)

parser.add_argument(
"-p",
"--print",
Expand All @@ -57,7 +66,9 @@ def main():

print("Login to Sumo environment: " + env)

sumo = SumoClient(args.env, interactive=args.interactive)
sumo = SumoClient(
args.env, interactive=args.interactive, devicecode=args.devicecode
)
token = sumo.authenticate()

if args.print_token:
Expand Down
2 changes: 2 additions & 0 deletions src/sumo/wrapper/sumo_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ def __init__(
env: str,
token: str = None,
interactive: bool = False,
devicecode: bool = False,
verbosity: str = "CRITICAL",
retry_strategy=RetryStrategy(),
):
Expand Down Expand Up @@ -81,6 +82,7 @@ def __init__(
interactive=interactive,
refresh_token=refresh_token,
access_token=access_token,
devicecode=devicecode,
)

if env == "localhost":
Expand Down