Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-introduce devicecode login as it can be useful in special situations #179

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Re-introduce devicecode login as it can be useful in special situations #179

merged 1 commit into from
Dec 5, 2023

Conversation

roywilly
Copy link
Contributor

@roywilly roywilly commented Dec 4, 2023

Trigger devicecode login only when flag is used on the sumo_login command.

@roywilly roywilly requested review from a team and rwiker December 4, 2023 11:38
@roywilly roywilly marked this pull request as ready for review December 4, 2023 12:53
rwiker
rwiker approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@rwiker rwiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rwiker rwiker merged commit 2668247 into main Dec 5, 2023
16 checks passed
@rwiker rwiker deleted the re-introduce-devicecode-login branch December 5, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwiker rwiker rwiker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roywilly @rwiker