-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 49 packages #93
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/epiverse-trace/tutorials/compare/md-outputs..md-outputs-PR-93 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2023-12-20 17:14:22 +0000 |
767ae98
to
e2745f4
Compare
This will partially fix #98 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ready to merge 🚀
Are you going to fix the epidemics version in a separate PR? |
I appreciate that reminder. I see two paths for this to fix {epidemics} and the errors in the current online version: (1) Update the episodes to the most recent (2) Keep the current version in the tutorials/renv/profiles/lesson-requirements/renv.lock Lines 562 to 585 in 215be1a
And replace the suggested installation:
Adding the tag version in it: pak::pak("epiverse-trace/epidemics@96a7b1457") @Bisaloo, please let me know if there would be any additional (or fewer) steps to take this PR as an opportunity to fix {epidemics}. @amanda-minter, can you do this fixing? It would depend on your time available. |
I would be fine with this in theory and happy to opt for this option in the future so we don't necessarily have to always keep up to date with the very latest version of epidemics. However, in this case, I suspect that different episodes were written with different versions of epidemics. This is my best guess to explain the error messages we currently have in the "Simulating transmission" episode: https://epiverse-trace.github.io/tutorials/simulating-transmission.html#introduction So either we table this for now, merge this PR with a note that this needs to be resolved as soon as possible (either by using the epidemics version from |
Let's try doing (2) to solve the website output. If this does not work, we'll proceed with (1) after this PR. I identified that the maintainer can do (2) and the developer can do (1), so I'll add the version tag. |
@Bisaloo so, this should be ready to merge. |
Flagging that as per 60db9e0, this is causing even more errors than previously. |
I'll do the merge. I expect that removing the installation lines from the .Rmd files in this PR allow using the registered {epidemics} version in the renv.lock. |
🤖 This is an automated build
This will update 49 packages in your lesson with the following versions:
⏱️ In a few minutes, a comment will appear that will show you how the output has changed based on these updates.
If you want to inspect these changes locally, you can use the following code to check out a new branch: