Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lintr continuous integration #96

Merged
merged 10 commits into from
Jan 29, 2024
Merged

Add lintr continuous integration #96

merged 10 commits into from
Jan 29, 2024

Conversation

Bisaloo
Copy link
Member

@Bisaloo Bisaloo commented Dec 18, 2023

This is on hold until #93 is merged since it will already remove a bunch of lints.

Please disregard the failing check. It is expected and innocuous.

Copy link

github-actions bot commented Dec 18, 2023

⚠️ WARNING ⚠️

This pull request contains a mix of workflow files and regular files. This could be malicious. No preview will be created.

regular files:

  • .lintr
  • episodes/compare-interventions.Rmd
  • episodes/model-choices.Rmd
  • episodes/modelling-interventions.Rmd
  • episodes/simulating-transmission.Rmd
  • episodes/template.Rmd
  • renv/profiles/lesson-requirements/renv.lock

workflow files:

  • .github/workflows/lint.yaml

@Bisaloo Bisaloo force-pushed the lintr branch 2 times, most recently from 1852a2f to 814de7c Compare December 20, 2023 20:23
@Bisaloo Bisaloo requested a review from avallecam December 21, 2023 09:19
@Bisaloo Bisaloo marked this pull request as ready for review December 21, 2023 18:47
@Bisaloo Bisaloo force-pushed the lintr branch 2 times, most recently from 1f8805a to 0fcd994 Compare December 21, 2023 22:10
Copy link
Member

@avallecam avallecam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding {lintr} to this repo! It is a polite way to police a homogeneous writing aesthetic. I liked the homogenization of require/library and the isolation of argument object names in different lines.

Thanks to this PR, I also found the need to open #108 , so the nolint will be displaced at some moment after emerging other PRs.

I asked some questions that probably require some changes before merging.

episodes/compare-interventions.Rmd Show resolved Hide resolved
episodes/model-choices.Rmd Outdated Show resolved Hide resolved
renv/profiles/lesson-requirements/renv.lock Show resolved Hide resolved
@avallecam avallecam mentioned this pull request Jan 23, 2024
@avallecam
Copy link
Member

avallecam commented Jan 23, 2024

⚠️ WARNING ⚠️

This pull request contains a mix of workflow files and regular files. This could be malicious. No preview will be created.

One additional question. About the warning in the second message of this PR, should we isolate the workflow and regular file edits in different PRs?

@Bisaloo
Copy link
Member Author

Bisaloo commented Jan 25, 2024

One additional question. About #96 (comment), should we isolate the workflow and regular file edits in different PRs?

It's fine in this specific case.

This warning is here because there is a risk someone could steal private GitHub info from of our organization in such a PR. This security element is good in general. In this specific case, you don't have anything to worry about since I already have access to all our of organization settings.

Copy link
Member

@avallecam avallecam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the recent updates. Ready to merge! 🚀

Copy link
Member

@avallecam avallecam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I want to add the brief edit suggested in #108

Copy link
Member

@avallecam avallecam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if appropriate, these suggested changes can help to solve #108

episodes/simulating-transmission.Rmd Outdated Show resolved Hide resolved
episodes/simulating-transmission.Rmd Outdated Show resolved Hide resolved
episodes/simulating-transmission.Rmd Outdated Show resolved Hide resolved
Copy link
Member

@avallecam avallecam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the latest updates! ready to merge 🚀

@Bisaloo Bisaloo merged commit 35b34d4 into main Jan 29, 2024
3 of 4 checks passed
@Bisaloo Bisaloo deleted the lintr branch January 29, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants