-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Middle task tutorials #58
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/epiverse-trace/tutorials/compare/md-outputs..md-outputs-PR-58 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-02-02 20:02:03 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice tutorials! I've left some comments in specific places.
Some of the syntax is currently undergoing some breaking changes with a target of version 2.0.0 - we'll have to decide whether to publish these as 1.4.0 specific tutorials or wait until the new version and then make any necessary changes.
@sbfnk thank you for the previous comments, I've added two further sections to the second tutorial "Create a short-term forecast"
If you have time to look at these new sections before Christmas I can any make necessary changes, I will leave these changes as a draft PR regardless so that the tutorials can be updated for EpiNow2 2.0.0 before being made public |
FYI yesterday I change this to ready to review since all workbench gh-actions passed and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great - just a few minor text changes.
Only question that remains is why we don't run the code in the solution - not doing this seems to open ourselves for issues if there are any bugs in the code.
Good question. Days ago, I had issues making that section pass the workbench gh-actions, although running correctly locally. But I didn't consider that potential vulnerability. I'll open it again and look further if issues appear. |
Great - yes, I noticed some issues with version from a weeks ago that I managed to fix locally (but things had moved on since then). Feel free to ping me for a second pair of eyes if you run into any issues. |
Co-authored-by: Sebastian Funk <[email protected]>
Co-authored-by: Sebastian Funk <[email protected]>
Co-authored-by: Sebastian Funk <[email protected]>
Co-authored-by: Sebastian Funk <[email protected]>
Co-authored-by: Sebastian Funk <[email protected]>
@sbfnk changes incorporated and all checks passed. Thank you for your feedback. Re-requesting review for approval and proceed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super!
Co-authored-by: Sebastian Funk <[email protected]>
Tutorials for middle tasks 1 (Quantifying transmissibility) and 2 (Create a short-term forecast )