-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add episodes on introduction and read delays #104
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/epiverse-trace/tutorials/compare/md-outputs..md-outputs-PR-104 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-02-06 13:41:38 +0000 |
The error I get when trying to run clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [Matrix.so] Error 1
ERROR: compilation failed for package ‘Matrix’ |
I have {Matrix} installed: > library(Matrix)
> packageVersion("Matrix")
[1] ‘1.5.3’ I've updated to the latest version, which installs correctly: > install.packages("Matrix")
trying URL 'https://cran.rstudio.com/bin/macosx/big-sur-arm64/contrib/4.2/Matrix_1.6-5.tgz'
Content type 'application/x-gzip' length 5348209 bytes (5.1 MB)
==================================================
downloaded 5.1 MB
The downloaded binary packages are in
/var/folders/c2/bn46nm4j7mj2_zyktygmfnk40000gp/T//RtmpAofVU8/downloaded_packages
> library(Matrix)
> packageVersion("Matrix")
[1] ‘1.6.5’ These are the versions of the carpentries packages I have installed: library(sandpaper)
library(varnish)
library(pegboard)
library(tinkr)
sessionInfo()
#> R version 4.2.3 (2023-03-15)
#> Platform: aarch64-apple-darwin20 (64-bit)
#> Running under: macOS 14.1.2
#>
#> Matrix products: default
#> BLAS: /Library/Frameworks/R.framework/Versions/4.2-arm64/Resources/lib/libRblas.0.dylib
#> LAPACK: /Library/Frameworks/R.framework/Versions/4.2-arm64/Resources/lib/libRlapack.dylib
#>
#> locale:
#> [1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8
#>
#> attached base packages:
#> [1] stats graphics grDevices utils datasets methods base
#>
#> other attached packages:
#> [1] tinkr_0.2.0 pegboard_0.7.1.9000 varnish_0.3.3.9000
#> [4] sandpaper_0.14.1.9000
#>
#> loaded via a namespace (and not attached):
#> [1] rstudioapi_0.14 xml2_1.3.3 knitr_1.44 magrittr_2.0.3
#> [5] R.cache_0.16.0 R6_2.5.1 rlang_1.1.2 fastmap_1.1.1
#> [9] styler_1.10.0 tools_4.2.3 xfun_0.40 R.oo_1.25.0
#> [13] cli_3.6.2 withr_2.5.2 htmltools_0.5.6 yaml_2.3.7
#> [17] digest_0.6.33 assertthat_0.2.1 lifecycle_1.0.4 processx_3.8.2
#> [21] purrr_1.0.2 callr_3.7.3 ps_1.7.5 vctrs_0.6.5
#> [25] R.utils_2.12.2 fs_1.6.3 glue_1.6.2 evaluate_0.23
#> [29] rmarkdown_2.25 reprex_2.0.2 compiler_4.2.3 R.methodsS3_1.8.2 Created on 2024-01-15 with reprex v2.0.2 |
I've updated the carpentries packages to see if that was the issue: library(sandpaper)
library(varnish)
library(pegboard)
library(tinkr)
sessionInfo()
#> R version 4.2.3 (2023-03-15)
#> Platform: aarch64-apple-darwin20 (64-bit)
#> Running under: macOS 14.1.2
#>
#> Matrix products: default
#> BLAS: /Library/Frameworks/R.framework/Versions/4.2-arm64/Resources/lib/libRblas.0.dylib
#> LAPACK: /Library/Frameworks/R.framework/Versions/4.2-arm64/Resources/lib/libRlapack.dylib
#>
#> locale:
#> [1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8
#>
#> attached base packages:
#> [1] stats graphics grDevices utils datasets methods base
#>
#> other attached packages:
#> [1] tinkr_0.2.0 pegboard_0.7.3 varnish_1.0.1 sandpaper_0.16.2
#>
#> loaded via a namespace (and not attached):
#> [1] rstudioapi_0.14 xml2_1.3.3 knitr_1.44 magrittr_2.0.3
#> [5] R.cache_0.16.0 R6_2.5.1 rlang_1.1.2 fastmap_1.1.1
#> [9] styler_1.10.0 tools_4.2.3 xfun_0.40 R.oo_1.25.0
#> [13] cli_3.6.2 withr_2.5.2 htmltools_0.5.6 yaml_2.3.7
#> [17] digest_0.6.33 assertthat_0.2.1 lifecycle_1.0.4 processx_3.8.2
#> [21] purrr_1.0.2 callr_3.7.3 ps_1.7.5 vctrs_0.6.5
#> [25] R.utils_2.12.2 fs_1.6.3 glue_1.6.2 evaluate_0.23
#> [29] rmarkdown_2.25 reprex_2.0.2 compiler_4.2.3 R.methodsS3_1.8.2 Created on 2024-01-15 with reprex v2.0.2 However, the same issue persists: clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [Matrix.so] Error 1
ERROR: compilation failed for package ‘Matrix’ This could be due to compiling the package on apple silicon. As the package version required by {tutorials} is v1.6-4, and I'm unsure where {sandpaper}/{renv} is installing from, but if a binary is not available it may cause issues with code requiring compilation, especially on Macs. |
Do you have the full install log from the failing Matrix installation please? |
What is the best way to share this? Paste a reprex of |
I suspect you're missing a fortran compiler / R doesn't find it. Can you try installing https://github.com/coatless-mac/macrtools first please? Carmen has had success with this in the past. |
I've used {macrtools} to install gfortran. Running The head and tail of the error message are:
|
It looks like you're probably missing system dependencies for ragg. Can you try running: pak::sysreqs_check_installed("ragg") please? |
pak::sysreqs_check_installed("ragg")
#> Error: ! error in pak subprocess
#> Caused by error in `sysreqs2_command(sysreqs_platform, "query")`:
#> ! Unknown OS. Don't know how to query or install system packages for
#> aarch64-apple-darwin20. Created on 2024-01-22 with reprex v2.0.2 |
That's unfortunate. Could you then look manually into ragg system dependencies and search if they are installed / how to install them on macOS? |
4 system dependencies for {ragg}: https://cran.r-project.org/web/packages/ragg/index.html I seem to have all system dependencies installed. Some possible problems:
|
I'm not really sure how to help. This is very specific to macOS and my knowledge is limited, as are my options to test potential fixes. If I was in this situation, my gut feeling would be to try and install webp related libraries that you may(???) be missing. No idea if that will help but probably worth a try. Otherwise:
|
I presume you've got webp installed? |
Reinstalled webp:
However, the {ragg} install still fails:
|
For what it's worth - I just went through the install steps on a macOS (Intel-based) device, with no major issues (I only had to manually install |
I think yes. That's a step we can add to the guidelines. I also noticed that for a successful local run of |
I agree, these problems are holding up this PR. I will unassign myself as a reviewer of this PR and will try to resolve these issues locally and with the team. |
0d5de1c
to
6b127fc
Compare
0f7e193
to
30583c9
Compare
e34b56f
to
0866c26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments that we should address after the split:
- there is a
cache/
folder in the output that probably shouldn't be here - most of the image should be converted to
.png
..jpg
is good for photographs but not for line art or scientific figures.
Thank you for your feedback.
Could it be because I used
Do you have a recommended method to do this conversion? I'll see if I can do this locally. |
I can do this locally 😅 |
Ideally, it shouldn't be a conversion since jpeg is a lossy format. The ideal solution would be to resave the images directly as png. |
thanks, hopefully, I did a direct resave as png. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some quality issues with some images. Please leave me a moment to update them from my side.
thanks, after your update, it would be informative to refer to the changes you perceived and how you solved them in the update. What I see when comparing the figures in the previous commit and the last commit is a brief increase in the file size. |
I didn't realize these figures were from articles, and they were provided as jpeg. This hurts my eyes 😭, and the proofing service should have fixed it before publication. But I'll remove the last commit then. If a figure has been saved as jpeg, we should keep it this way, even though it should have been a png in the first place. The idea of my first comment was that if we create a figure ourselves, it should be saved as png, not jpeg. |
Oh! now I understand. Yes, I did not create a figure yet. All I'd be happy if you remove the last commit, then. |
commit 0641875 is my worst commit ever! 🤣 I just realized I changed the figure's format but not change their names in the Rmd files, haha |
|
Fix #88
Fix #67
For context: I wrote two episodes, "introduction" and "read delays", as starting episodes around {EpiNow2} and {epiparameter} as a motivational example:
I'll appreciate your specific feedback providing a clear next step to remove, change or add content to this PR.
Some questions to guide this are:
For review, you can: