Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev fix and feat: plots, captions, sections, and removal of notification date distribution - INS comments #168

Merged
merged 54 commits into from
May 10, 2024
Merged

Dev fix and feat: plots, captions, sections, and removal of notification date distribution - INS comments #168

merged 54 commits into from
May 10, 2024

Conversation

GeraldineGomez
Copy link
Member

  • Please check if the PR fulfills these requirements
  • I have read the CONTRIBUTING guidelines
  • A new item has been added to NEWS.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Checks have been run locally and pass

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Fix comments related of expert review conducted by the National Institute of Health, new functions and some cleaning in the report template

  • What is the current behavior? (You can also link to an open issue here)
    Related issues:

  • What is the new behavior (if this is a feature change)?

    Report template:

    • Removed cases distribution related to notification date.
    • Adjusted captions of the plots, tables, and sections.
    • Added distribution of total geographic area and top 10 municipalities.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No, it does

@GeraldineGomez
fix: axis label Edad to Grupos de edad
1fb3ac9 
Ref: #154
@GeraldineGomez
feat(plot_per_etn): added porcentaje parameter and logic
0163bfd 
Ref: #154
@GeraldineGomez
feat: increase decimal number of percentage
0fc85b8 
Ref: #154
@GeraldineGomez
feat(plot_per_etn): added percentage parameter and label in bars
891dd1a 
Ref: #154
@GeraldineGomez
feat(agrupar_area_geo): modified logic to get the distribution only f…
95a28de 
…or geo areas

Ref: #154 & Ref: #146
@GeraldineGomez
chore(agrupar_area_geo): updated description and examples
fb11c7c 
Ref: #154 & Ref: #146
@GeraldineGomez
feat(plot_area_geo): modified logic to plot the distribution only for…
cecf4e0 
… geo areas

Ref: #154 & Ref: #146
@GeraldineGomez
chore(plot_area_geo): removed dpto parameter of the example
8e4bcff 
Ref: #154 & Ref: #146
@GeraldineGomez
feat: used previous logic of agrupar_area_geo to create the function
49165e8 
A new function called agrupar_top_area_geo has been created with the previous agrupar_area_geo logic and process.

Ref: #154 & Ref: #146
@GeraldineGomez
feat: added a new parameter called top
3ba2cad 
It includes a new parameter called top to return the numbers of rows indicated by the user and some optimizations.

Ref: #154 & Ref: #146
@GeraldineGomez
chore: added the description and example
665b8d8 
Ref: #154 & Ref: #146
@GeraldineGomez
feat: used the previous logic of plot_area_geo to create the function
ddec21e 
A new function called plot_top_area_geo has been created with the previous logic and process of plot_area_geo.

Ref: #154 & Ref: #146
@GeraldineGomez
chore: added the description and examples
18460bc 
Ref: #154 & Ref: #146
@GeraldineGomez
fix(plot_per_etn): lintr brackets
7cef2b6 
Ref: #154 & Ref: #146
@GeraldineGomez
chore(skeleton): added subsection with the municipalities top 10 by g…
5b31c70 
…eo are

Ref: #154 & Ref: #146
@GeraldineGomez
fix: removed agrupar_fecha_notifica function
76c7fa2 
This function has been removed due is redundant.

Ref: #154 & Ref: #146
@GeraldineGomez
fix: removed plot_fecha_notifica function
4ddaf4a 
This function has been removed due is redundant.

Ref: #154 & Ref: #146
@GeraldineGomez
fix: removed section Distribución de casos por fecha de notificación
39271cc 
Ref: #154 & Ref: #146
@GeraldineGomez
feat: added parameter estandar and its logic
1737275 
Ref: #154 & #146
@GeraldineGomez
chore: added documentation of parameter estandar
50d5a33 
Ref: #154  & #154
@GeraldineGomez
fix(plot_per_etn): added logic to regroup data event
469410c 
Ref: #154  & #154
@GeraldineGomez
fix(plot_per_etn): removed distinction between events in the plot
dcb9537 
Ref: #154  & #154
@GeraldineGomez
chore: removed function obtener_casos_pob_especial
f380ea2 
Ref: #160
@GeraldineGomez
chore: removed function agrupar_pob_especial
08994b4 
Ref: #160
@GeraldineGomez
fix(plot_map): removed index table of map visualisation
e7e55d1 
Ref: #146 & #161
@GeraldineGomez
chore(plot_map): added validation of fuente_data
11f3373 
Ref: #154
@GeraldineGomez
feat(plot_map): visualize the entire department and shade the municip…
35db370 
…ality

When the user wants to generate the map by municipality, They'll visualize the entire department and the municipality will shade in red.

Ref: #145
@GeraldineGomez
feat: change bar text color to white
5d91601 
Ref: #154
@GeraldineGomez
feat(plot_per_etn): added percentage in text bars
4bab08c 
Ref: #162
@GeraldineGomez
feat(plot_per_etn): collapse axis text labels
123f5b4 
Ref: #162
@GeraldineGomez GeraldineGomez self-assigned this May 10, 2024
@GeraldineGomez GeraldineGomez linked an issue May 10, 2024 that may be closed by this pull request
Remove logic of cases distribution by notification date #165
Closed
@GeraldineGomez GeraldineGomez merged commit fc6ff86 into main May 10, 2024
8 checks passed
@GeraldineGomez GeraldineGomez deleted the fix-ins-plots-154 branch May 10, 2024 21:38
@GeraldineGomez GeraldineGomez linked an issue May 10, 2024 that may be closed by this pull request
Remove index table of map plot #161
Closed
@GeraldineGomez GeraldineGomez mentioned this pull request May 10, 2024
Closed
@GeraldineGomez GeraldineGomez linked an issue May 10, 2024 that may be closed by this pull request
Fix some section description in report template #164
Closed
@GeraldineGomez GeraldineGomez removed a link to an issue May 10, 2024
Fix some section description in report template #164
Closed
@GeraldineGomez GeraldineGomez linked an issue May 10, 2024 that may be closed by this pull request
Fix some section description in report template #164
Closed
This was referenced May 10, 2024
Closed
Closed
This was linked to issues May 10, 2024
Add geography occurrence in table caption of incidence by geo distribution #163
Closed
Add percentage in bars text of plot_per_etn function #162
Closed
This was referenced May 10, 2024
Closed
Closed
@GeraldineGomez GeraldineGomez linked an issue May 10, 2024 that may be closed by this pull request
Remove functions related to special populations #160
Closed
@GeraldineGomez GeraldineGomez mentioned this pull request May 10, 2024
Closed
@GeraldineGomez GeraldineGomez linked an issue May 10, 2024 that may be closed by this pull request
Fix plot axis labels #154
Closed
This was referenced May 10, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GeraldineGomez GeraldineGomez

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@GeraldineGomez