Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comentarios SIVIREP #146

Closed
chuguett opened this issue Apr 25, 2024 · 3 comments
Closed

Comentarios SIVIREP #146

chuguett opened this issue Apr 25, 2024 · 3 comments
Assignees
@GeraldineGomez
Labels
enhancement New feature or request plots template

Comments

@chuguett
Copy link

Es una buena aproximación al análisis exploratorio de las bases publicas de Sivigila, algunas mejoras de "forma" incluyen:

Los ejes de edad son "grupos de edad" no edades simples.
Nombrar las gráficas en la parte superior.
La gráfica de fecha de notificación esta repetida con la gráfica de fecha por inicio de síntomas.

Un cambio importante es que Dengue y Malaria se debe calcular sobre la población a riesgo que provee Ministerio de Salud y no sobre población total de las proyecciones DANE.

Muchas gracias por el trabajo porque permite automatizar el proceso de análisis descriptivo de históricos.
@GeraldineGomez
Copy link
Member

Hola @chuguett,

Muchas gracias por tus comentarios y recomendaciones 😊😊😊

Procederemos a separar cada una de las mejoras solicitadas en diferentes issues con el fin de generar trazabilidad en la historia de GitHub. Te estaremos notificando la resolución de los mismos.

@GeraldineGomez GeraldineGomez mentioned this issue May 7, 2024
Closed
GeraldineGomez added a commit that referenced this issue May 7, 2024
@GeraldineGomez
feat(agrupar_area_geo): modified logic to get the distribution only f…
95a28de 
…or geo areas

Ref: #154 & Ref: #146
GeraldineGomez added a commit that referenced this issue May 7, 2024
@GeraldineGomez
chore(agrupar_area_geo): updated description and examples
fb11c7c 
Ref: #154 & Ref: #146
GeraldineGomez added a commit that referenced this issue May 7, 2024
@GeraldineGomez
feat(plot_area_geo): modified logic to plot the distribution only for…
cecf4e0 
… geo areas

Ref: #154 & Ref: #146
GeraldineGomez added a commit that referenced this issue May 7, 2024
@GeraldineGomez
chore(plot_area_geo): removed dpto parameter of the example
8e4bcff 
Ref: #154 & Ref: #146
GeraldineGomez added a commit that referenced this issue May 7, 2024
@GeraldineGomez
feat: used previous logic of agrupar_area_geo to create the function
49165e8 
A new function called agrupar_top_area_geo has been created with the previous agrupar_area_geo logic and process.

Ref: #154 & Ref: #146
GeraldineGomez added a commit that referenced this issue May 7, 2024
@GeraldineGomez
feat: added a new parameter called top
3ba2cad 
It includes a new parameter called top to return the numbers of rows indicated by the user and some optimizations.

Ref: #154 & Ref: #146
GeraldineGomez added a commit that referenced this issue May 7, 2024
@GeraldineGomez
chore: added the description and example
665b8d8 
Ref: #154 & Ref: #146
GeraldineGomez added a commit that referenced this issue May 7, 2024
@GeraldineGomez
feat: used the previous logic of plot_area_geo to create the function
ddec21e 
A new function called plot_top_area_geo has been created with the previous logic and process of plot_area_geo.

Ref: #154 & Ref: #146
GeraldineGomez added a commit that referenced this issue May 7, 2024
@GeraldineGomez
chore: added the description and examples
18460bc 
Ref: #154 & Ref: #146
GeraldineGomez added a commit that referenced this issue May 7, 2024
@GeraldineGomez
fix(plot_per_etn): lintr brackets
7cef2b6 
Ref: #154 & Ref: #146
GeraldineGomez added a commit that referenced this issue May 7, 2024
@GeraldineGomez
chore(skeleton): added subsection with the municipalities top 10 by g…
5b31c70 
…eo are

Ref: #154 & Ref: #146
GeraldineGomez added a commit that referenced this issue May 7, 2024
@GeraldineGomez
fix: removed agrupar_fecha_notifica function
76c7fa2 
This function has been removed due is redundant.

Ref: #154 & Ref: #146
GeraldineGomez added a commit that referenced this issue May 7, 2024
@GeraldineGomez
fix: removed plot_fecha_notifica function
4ddaf4a 
This function has been removed due is redundant.

Ref: #154 & Ref: #146
GeraldineGomez added a commit that referenced this issue May 7, 2024
@GeraldineGomez
fix: removed section Distribución de casos por fecha de notificación
39271cc 
Ref: #154 & Ref: #146
GeraldineGomez added a commit that referenced this issue May 8, 2024
@GeraldineGomez
feat: added parameter estandar and its logic
1737275 
Ref: #154 & #146
GeraldineGomez added a commit that referenced this issue May 9, 2024
@GeraldineGomez
fix(plot_map): removed index table of map visualisation
e7e55d1 
Ref: #146 & #161
GeraldineGomez added a commit that referenced this issue May 9, 2024
@GeraldineGomez
chore(skeleton): updated width of spatial distribution map
38068f8 
Ref: #146 & #161
GeraldineGomez added a commit that referenced this issue May 9, 2024
@GeraldineGomez
fix: removed description related to distribution by notification date
97dbc85 
Ref: #146 & #164
@GeraldineGomez GeraldineGomez mentioned this issue May 10, 2024
Merged
5 tasks
GeraldineGomez added a commit that referenced this issue May 10, 2024
@GeraldineGomez
feat(agrupar_area_geo): modified logic to get the distribution only f…
e38c90a 
…or geo areas

Ref: #154 & Ref: #146
GeraldineGomez added a commit that referenced this issue May 10, 2024
@GeraldineGomez
chore(agrupar_area_geo): updated description and examples
dad5c46 
Ref: #154 & Ref: #146
GeraldineGomez added a commit that referenced this issue May 10, 2024
@GeraldineGomez
feat(plot_area_geo): modified logic to plot the distribution only for…
b098dcc 
… geo areas

Ref: #154 & Ref: #146
GeraldineGomez added a commit that referenced this issue May 10, 2024
@GeraldineGomez
chore(plot_area_geo): removed dpto parameter of the example
ca76e86 
Ref: #154 & Ref: #146
GeraldineGomez added a commit that referenced this issue May 10, 2024
@GeraldineGomez
feat: used previous logic of agrupar_area_geo to create the function
36f963f 
A new function called agrupar_top_area_geo has been created with the previous agrupar_area_geo logic and process.

Ref: #154 & Ref: #146
GeraldineGomez added a commit that referenced this issue May 10, 2024
@GeraldineGomez
feat: added a new parameter called top
5907b0a 
It includes a new parameter called top to return the numbers of rows indicated by the user and some optimizations.

Ref: #154 & Ref: #146
GeraldineGomez added a commit that referenced this issue May 10, 2024
@GeraldineGomez
chore: added the description and example
ea0253e 
Ref: #154 & Ref: #146
GeraldineGomez added a commit that referenced this issue May 10, 2024
@GeraldineGomez
feat: used the previous logic of plot_area_geo to create the function
606350a 
A new function called plot_top_area_geo has been created with the previous logic and process of plot_area_geo.

Ref: #154 & Ref: #146
GeraldineGomez added a commit that referenced this issue May 10, 2024
@GeraldineGomez
chore: added the description and examples
0e7a667 
Ref: #154 & Ref: #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
chore(calcular_incidencia_sex): updated documentation with the new lo…
1e35245 
…gic for population and year

Ref: #172 & #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
feat(skeleton): added top caption position
9e0fb96 
Ref: #172 & #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
feat(skeleton): removed proyecciones reference
0a5cc5b 
Ref: #172 & #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
feat(skeleton): removed year parameter in functions of incidence calc…
6687b26 
…ulation

Ref: #172 & #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
fix(plot_per_etn): removed percentage in bars
e51884b 
Ref: #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
fix: lintr lenght
63286bf 
Ref: #172 & #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
fix(obtener_pob_incidencia): warning messages to avoid words year or …
25e9db8 
…anio and name event

Ref: #172 & #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
fix(calcular_incidencia_sex): warning messages to avoid words anio, y…
abee04f 
…ear and the event's name

Ref: #172 & #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
fix(import_pob_riesgo): conditional to get risk pop of event subtypes
acb18cb 
Ref: #172 & #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
chore(skeleton): added point
9f31da7 
Ref: #172 & #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
fix(skeleton): width and height of ethnicity plot
32059dd 
Ref: #172 & #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
fix(import_pob_riesgo): added casting to character for cod_eve
644982e 
Ref: #172 & #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
chore(README): updated authors and contributors
44265a9 
Ref: #172 & #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
chore(DESCRIPTION): updated authors and contributors
7bb9940 
Ref: #172 & #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
fix(obtener_cond_inciden_event): included additional columns
97e0c8f 
Ref: #172 & #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
fix: added logic to special events - Malaria
07c23e5 
Ref: #172 & #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
fix: added key special_events - Malaria
dac577a 
Ref: #172 & #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
fix: logic to obtain incidence formula (population) by event based on…
3a1484c 
… INS protocol

Ref: #172 & #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
chore: updated default value of population parameter to NULL
93f2176 
Ref: #172 & #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
fix: replaced toupper with tolower for the year label
eef95a1 
Ref: #172 & #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
fix: removed event name in the warning message
663a753 
Ref: #172 & #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
feat: added conditions for the numerator and denominator
5d1552f 
Ref: #172 & #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
fix: added default logic when the ins protocol is not clear
c37a2ce 
Ref: #172 & #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
fix: added n_distinct for dpto and mpio logic
690491c 
Ref: #172 & #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
fix: removed logic of empty incidence conditions
67ddec1 
Ref: #172 & #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
chore: replaced XLSX file with RDA file for the event's incidence for…
9e1413f 
…mula

Ref: #172 & #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
chore: updated incidence_events key to reference rda file
2b11a42 
Ref: #172 & #146
GeraldineGomez added a commit that referenced this issue May 18, 2024
@GeraldineGomez
chore: replaced logic with XLSX file with RDA file to obtain the form…
dbc529e 
…ula for event incidence calculation

Ref: #172 & #146
@GeraldineGomez
Copy link
Member

GeraldineGomez commented May 18, 2024 •
edited
Loading

Buen día @chuguett,

Todos los ítems fueron resueltos a través de la creación de otros issues y los siguientes PR:

Muchas gracias!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GeraldineGomez GeraldineGomez

Labels
enhancement New feature or request plots template
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GeraldineGomez @chuguett