add ecds support for composite filter #29289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rama Chavali <[email protected]>
Signed-off-by: Rama Chavali <[email protected]>
Signed-off-by: Rama Chavali <[email protected]>
Signed-off-by: Rama Chavali <[email protected]>
Signed-off-by: Rama Chavali <[email protected]>
Signed-off-by: Rama Chavali <[email protected]>
Signed-off-by: Rama Chavali <[email protected]>
Signed-off-by: Rama Chavali <[email protected]>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Rama Chavali <[email protected]>
Signed-off-by: Rama Chavali <[email protected]>
Signed-off-by: Rama Chavali <[email protected]>
Signed-off-by: Rama Chavali <[email protected]>
Signed-off-by: Rama Chavali <[email protected]>
Signed-off-by: Rama Chavali <[email protected]>
Signed-off-by: Rama Chavali <[email protected]>
Signed-off-by: Rama Chavali <[email protected]>
Signed-off-by: Rama Chavali <[email protected]>
Signed-off-by: Rama Chavali <[email protected]>
Signed-off-by: Rama Chavali <[email protected]>
Signed-off-by: Rama Chavali <[email protected]>
Signed-off-by: Rama Chavali <[email protected]>
Signed-off-by: Rama Chavali <[email protected]>
Signed-off-by: Rama Chavali <[email protected]>
Signed-off-by: Rama Chavali <[email protected]>
Signed-off-by: Rama Chavali <[email protected]>
kyessenov
approved these changes
Dec 8, 2023
|
@alyssawilk Can you please approve and merge? |
alyssawilk
approved these changes
Dec 11, 2023
|
I think this needs one more main merge to pass the new CI checks |
Signed-off-by: Rama Chavali <[email protected]>
|
/retest |
Signed-off-by: Rama Chavali <[email protected]>
|
@alyssawilk merged main. But coverage for quic seem to fail and buffer integration test is flaky? |
I've seen the same quic coverage failure in another PR (#31287), not sure if it is flaky or not. |
|
yeah I think @phlax bumped quic coverage last night |
|
/wait on CI |
Signed-off-by: Rama Chavali <[email protected]>
wbpcode
added a commit
to wbpcode/envoy
that referenced
this pull request
Dec 20, 2023
Signed-off-by: wbpcode <[email protected]>
wbpcode
pushed a commit
that referenced
this pull request
Dec 20, 2023
* clean server factory context and partly revert #29289 Signed-off-by: wbpcode <[email protected]> * minor update Signed-off-by: wbpcode <[email protected]> --------- Signed-off-by: wbpcode <[email protected]>
mum4k
pushed a commit
to envoyproxy/nighthawk
that referenced
this pull request
Dec 20, 2023
- Update the ENVOY_COMMIT and ENVOY_SHA in bazel/repositories.bzl to the latest Envoy's commit. - Update to .bazelrc to envoyproxy/envoy#31372 - Update source/client/process_impl.cc to support pure virtual function change introduced in envoyproxy/envoy#29289 - Temporarily disable test_gcc target to unblock import. GCC version was updated with new images envoyproxy/envoy#31372 which now fail on various warnings. Signed-off-by: tomjzzhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: add ecds support for composite filter
Additional Description: Currrently ECDS does not support composite filter. This would help to use composite filter for use cases like WASM filters
Risk Level: Low
Testing: Updated
Docs Changes: Updated
Release Notes: Added