clean server factory context and partly revert #29289 #31458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wbpcode <[email protected]>
wbpcode
requested review from
alyssawilk,
mattklein123 and
yanavlasov
as code owners
Signed-off-by: wbpcode <[email protected]>
|
cc @ramaraochavali I believe this won't effect ecds support in the composite filter. |
|
Hi, @mattklein123 could you take a look at this patch when you have free time, thanks :). @alyssawilk is on her vocation. |
As long as composite integration test passes we should be good :-) cc: @kyessenov |
mattklein123
approved these changes
Dec 20, 2023
mum4k
pushed a commit
to envoyproxy/nighthawk
that referenced
this pull request
Dec 21, 2023
- Update the ENVOY_COMMIT and ENVOY_SHA in bazel/repositories.bzl to the latest Envoy's commit. - Update stream_decoder to support envoyproxy/envoy#31141 - Update source/client/process_impl.cc to support envoyproxy/envoy#31458 - Re-enable test_gcc target to resolve #1049 since we've included envoyproxy/envoy#31470 Signed-off-by: tomjzzhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: clean server factory context and partly revert #29289
Additional Description:
#29289 added ECDS support to the composite filter which is great. But it also introduced a new method to the server factory context which is not recommended.
SingletonManager is better choice to achieve this target. If more stable lifetime is necessary, then a pinned singleton instance should be enough.
Risk Level: low.
Testing: n/a.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.