Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument grouping for ZK proofs #169

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Conversation

fjarri
Copy link
Member

@fjarri fjarri commented Dec 17, 2024

Stacked on top of #166

Group secret and public inputs into structs to make it more transparent which variables are substituted at the points of their use (since the variable names in the protocols don't always correspond to the variable names in the proofs)

@fjarri fjarri self-assigned this Dec 17, 2024
@fjarri fjarri requested a review from dvdplm December 17, 2024 20:23
@fjarri fjarri mentioned this pull request Dec 17, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 89.23077% with 56 lines in your changes missing coverage. Please review.

Project coverage is 93.06%. Comparing base (a7dc794) to head (a2fe42a).

Files with missing lines Patch % Lines
synedrion/src/cggmp21/interactive_signing.rs 75.22% 56 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
- Coverage   93.23%   93.06%   -0.17%     
==========================================
  Files          36       36              
  Lines        6858     7012     +154     
==========================================
+ Hits         6394     6526     +132     
- Misses        464      486      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dvdplm dvdplm merged commit 423f1b5 into entropyxyz:master Dec 19, 2024
9 of 11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
@fjarri fjarri deleted the zk-arg-grouping branch December 19, 2024 19:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants