-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for CGGMP'24 #170
Draft
fjarri
wants to merge
18
commits into
entropyxyz:master
Choose a base branch
from
fjarri:new-cggmp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Updates for CGGMP'24 #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #170 +/- ##
==========================================
- Coverage 93.06% 92.38% -0.69%
==========================================
Files 36 40 +4
Lines 7012 7734 +722
==========================================
+ Hits 6526 7145 +619
- Misses 486 589 +103 ☔ View full report in Codecov by Sentry. |
fjarri
force-pushed
the
new-cggmp
branch
8 times, most recently
from
December 21, 2024 22:31
996e6ee
to
588f3ba
Compare
To replace the old dec when we are converting Presigning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #157
PAPER.md
, removed obsolete items.±2^l
now means[-2^(l-1)+1, 2^(l-1)]
instead of the previous[-2^l, 2^l]
). This caused a bit of a chain reaction:SecretSigned::assert_exponent_range()
logic changed.SecretSigned::random_in_exp_range*()
logic changed, and alsoexp
was changed toexponent
to match the assertion name.PublicSigned::from_xof_reader_bounded()
changed its behavior to produce the number according to the new range definition, and was renamed tofrom_xof_reader_in_range()
.PublicSigned::in_range_bits()
changed its behavior according to the new range definition, and was renamed tois_in_exponent_range()
.Ciphertext
constructor they are passed asSecretSigned
, to comply with the range requirements in the proofs.conversions::secret_unsigned_from_scalar()
removed.SecretSigned::new_modulo()
constructor to make a signed number in range [-N/2, N/2] from an Uint in range [0, N).Ciphertext::new()
anddecrypt()
(which took unsigned plaintexts), renamednew_signed()
anddecrypt_signed()
tonew()
anddecrypt()
.Ciphertext::new_with_randomizer()
was renamed tonew_with_randomizer_unsigned()
, since it's now a special one, only used in P_mul. Renamednew_with_randomizer_signed()
tonew_with_randomizer()
, andnew_public_with_randomizer_signed()
tonew_public_with_randomizer()
.e <-- ±q
is used, we are sampling the challenge as aScalar
using the newScalar::from_xof_reader()
method (and using that inП^sch
as well).aff-g
proof.prm
proof, and started usingBitVec
for its commitment.dec
proof (there were significant changes). Temporarily, it is located indec_new.rs
, will be moved todec.rs
whenPresigning
is updated.elog
proof.enc-elg
proof.aff-g*
proof.fac
proof, and implemented necessary changes to the algorithm (some variables are calculated differently, and the challenge is now a signedUint
and not aScalar
)mod
proof, and enforced invertibility conditions that were added in '24sch
proofIsInvertible
trait, documenting the choice between GCD andinvert()