-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signed
improvements
#166
Signed
improvements
#166
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #166 +/- ##
==========================================
+ Coverage 93.16% 93.26% +0.09%
==========================================
Files 34 36 +2
Lines 7026 6858 -168
==========================================
- Hits 6546 6396 -150
+ Misses 480 462 -18 ☔ View full report in Codecov by Sentry. |
47fd19e
to
0b9eba1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pheew, a big one!
Overall LGTM; left some nitpicks, suggestions and questions.
There's some inconsistency in what is documented and what isn't, and I think we should avoid asserts in favour of Result
wherever possible, although I don't consider it a blocker for this PR.
45b463c
to
f817f12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to go yeah?
I was waiting for your response to the last round of changes, and I'm guessing you're fine with them. Merging. |
f817f12
to
4dd0040
Compare
Signed
andBounded
intoSecretSigned
,PublicSigned
, andSecretUnsigned
.SecretSigned/Unsigned
(fixes Zeroizing follow-up:Signed
#165, fixes Wraptotient_nonzero
in a SecretBox #146)Exponentiable
trait (part of Multiplication/exponentiation speed-ups #34)Remaining work (for other PRs):
MontyParams
of RSA primes #162 (have to wait until the next release ofcrypto-bigint
)Scalar
always-secret too? Do we ever use non-secret scalars?