Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signed improvements #166

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Signed improvements #166

merged 4 commits into from
Dec 19, 2024

Conversation

fjarri
Copy link
Member

@fjarri fjarri commented Dec 10, 2024

Remaining work (for other PRs):

@fjarri fjarri self-assigned this Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 97.43809% with 30 lines in your changes missing coverage. Please review.

Project coverage is 93.26%. Comparing base (3a45cdd) to head (f817f12).

Files with missing lines Patch % Lines
synedrion/src/uint/secret_signed.rs 96.69% 14 Missing ⚠️
synedrion/src/uint/public_signed.rs 93.33% 8 Missing ⚠️
synedrion/src/cggmp21/interactive_signing.rs 76.00% 6 Missing ⚠️
synedrion/src/paillier/encryption.rs 99.00% 1 Missing ⚠️
synedrion/src/uint/secret_unsigned.rs 98.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
+ Coverage   93.16%   93.26%   +0.09%     
==========================================
  Files          34       36       +2     
  Lines        7026     6858     -168     
==========================================
- Hits         6546     6396     -150     
+ Misses        480      462      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fjarri fjarri marked this pull request as ready for review December 13, 2024 03:01
@fjarri fjarri requested a review from dvdplm December 13, 2024 03:09
@fjarri fjarri force-pushed the better-signed branch 2 times, most recently from 47fd19e to 0b9eba1 Compare December 13, 2024 06:26
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pheew, a big one!

Overall LGTM; left some nitpicks, suggestions and questions.

There's some inconsistency in what is documented and what isn't, and I think we should avoid asserts in favour of Result wherever possible, although I don't consider it a blocker for this PR.

synedrion/src/cggmp21/conversion.rs Show resolved Hide resolved
synedrion/src/cggmp21/conversion.rs Outdated Show resolved Hide resolved
synedrion/src/cggmp21/conversion.rs Outdated Show resolved Hide resolved
synedrion/src/cggmp21/conversion.rs Show resolved Hide resolved
synedrion/src/cggmp21/conversion.rs Show resolved Hide resolved
synedrion/src/paillier/encryption.rs Outdated Show resolved Hide resolved
synedrion/src/tools/secret.rs Outdated Show resolved Hide resolved
synedrion/src/uint/secret_signed.rs Outdated Show resolved Hide resolved
synedrion/src/uint/secret_signed.rs Outdated Show resolved Hide resolved
synedrion/src/uint/secret_signed.rs Outdated Show resolved Hide resolved
@fjarri fjarri force-pushed the better-signed branch 2 times, most recently from 45b463c to f817f12 Compare December 17, 2024 05:57
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go yeah?

@fjarri
Copy link
Member Author

fjarri commented Dec 19, 2024

I was waiting for your response to the last round of changes, and I'm guessing you're fine with them. Merging.

@fjarri fjarri merged commit a7dc794 into entropyxyz:master Dec 19, 2024
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
@fjarri fjarri deleted the better-signed branch December 19, 2024 03:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zeroizing follow-up: Signed Zeroize MontyParams of RSA primes Wrap totient_nonzero in a SecretBox
2 participants