This repository has been archived by the owner on Dec 27, 2023. It is now read-only.
Drop global BoardType enum in favor of driver-specific configuration struct #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plaes
force-pushed
the
rework-boardtype
branch
from
84ea8d0 to
fd3db19
Compare
plaes
force-pushed
the
rework-boardtype
branch
from
655a79f to
06dd454
Compare
plaes
force-pushed
the
rework-boardtype
branch
from
06dd454 to
4a1e110
Compare
Instead of using lora-phy's BoardType/ChipType enum, switch to driver-specific configuration struct.
Instead of using lora-phy's BoardType/ChipType enum, switch to driver-specific configuration struct.
Now that all drivers are using board configuration structure, we can drop global ChipType enum.
Now that all drivers are using board configuration structure, we can drop global BoardType enum.
Now that BoardType/ChipType has been removed, we can drop unused BoardTypeUnsupportedForRadioKind error kind.
plaes
force-pushed
the
rework-boardtype
branch
from
4a1e110 to
a930c39
Compare
lucasgranberg
approved these changes
Oct 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor to get rid of global BoardType and ChipType enum in favor of interface-specific board configuration struct.
NB! Breaks existing APIs: