This repository has been archived by the owner on Dec 27, 2023. It is now read-only.
Add support for sx1272 chip to existing sx1276_7_8_9 driver #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
plaes
force-pushed
the
wip-sx1272
branch
2 times, most recently
from
36f6b01 to
d90b0d3
Compare
Current API needs some rethinking on how to actually configure the output port as it might need to be configured based on board setup (which output pin is actually used) and selected region (high frequency vs low frequency output).
plaes
changed the title
As set_tx_continuous_wave_mode touches some of the chip-specific registers, branch out the implementation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is initial RFC PR for sx1272 support added into existing sx1276+ driver.
It's now good enough to rx/tx P2P packets, but there's some work still left to deal with preamble support (will be handled in separate PR).
While implementing support, I have ran into following issues where each of these probably warrants its own design discussion:
Tcxo support - currently it is assumed to be always enabled, but instead it should be handled via board configuration (see the final commit).lora.prepare_for_tx(..))Dio configuration - should allow more pins.. ?- Handled via interface.Type leakage.. (ie I had to addBoardType::GenericSx1272intosx1261_2driver)