Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 80MHz tick rate #1962

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Add 80MHz tick rate #1962

merged 2 commits into from
Sep 28, 2023

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Sep 28, 2023

This PR attempts fixing this. The ESP32S2 seems to need to work with 80MHz SysTimer tick rates.

I didn't overcomplicate things, just added the single frequency manually. Maybe 2^x multiples of 10MHz could be added in general.

@Dirbaio
Copy link
Member

Dirbaio commented Sep 28, 2023

Maybe 2^x multiples of 10MHz could be added in general.

yes, now that it's shown that we have "holes" in the heuristic i'd just add more ways. Perhaps all multiples of 10mhz up to 300mhz, then multiples of 20 from there up to 1000mhz?

@bugadani
Copy link
Contributor Author

bugadani commented Sep 28, 2023

Might be a bit excessive until needed, don't you think? :) That's like what, 65 new features if my evening ballpark math is correct

Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's "just" a 2x increase. i'd rather not keep reviewing "add XXX tick rate" PRs 🥲

@Dirbaio Dirbaio added this pull request to the merge queue Sep 28, 2023
Merged via the queue into embassy-rs:main with commit b1b32f0 Sep 28, 2023
@bugadani bugadani deleted the esp32s2 branch September 28, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants