Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SysTimer as timebase on ESP32-S2 #827

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Support SysTimer as timebase on ESP32-S2 #827

merged 1 commit into from
Oct 12, 2023

Conversation

bugadani
Copy link
Contributor

Thank you!

Thank you for your contribution.
Please make sure that your submission includes the following:

Must

  • The code compiles without errors or warnings.
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You updated existing examples or added examples (if applicable).
  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code.

I'm pre-ticking the boxes, but this doesn't work until embassy-time 0.1.4 is released, including this PR: embassy-rs/embassy#1962

cc #253

@jessebraham jessebraham added the status:blocked Unable to progress - dependent on another task label Oct 11, 2023
@bugadani bugadani marked this pull request as ready for review October 12, 2023 16:46
@bugadani bugadani marked this pull request as draft October 12, 2023 16:48
@bugadani bugadani marked this pull request as ready for review October 12, 2023 16:58
@jessebraham jessebraham removed the status:blocked Unable to progress - dependent on another task label Oct 12, 2023
jessebraham
jessebraham approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@jessebraham jessebraham merged commit 5365031 into esp-rs:main Oct 12, 2023
@bugadani bugadani deleted the systimer branch October 12, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bugadani @jessebraham