Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2294 Accessibility violations fix - RadioButtons, Table Custom Buttons #2306

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open
Changes from 11 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,8 @@ class RadiosetControl extends React.Component {
orientation={this.props.control.orientation}
helperText={this.props.control.helperText}
readOnly={this.props.readOnly}
// Provide unique aria-label for each radio button group
aria-label={`Radio Button Group (${ControlUtils.getDataId(this.props.control, this.props.propertyId)})`}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be translated?

>
{buttons}
</RadioButtonGroup>
Expand Down
Loading