#2294 Accessibility violations fix - RadioButtons, Table Custom Buttons #2306
+18
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: srikant <[email protected]>
Signed-off-by: srikant <[email protected]>
Signed-off-by: srikant <[email protected]>
Signed-off-by: srikant <[email protected]>
…ing role and aria-label Signed-off-by: srikant <[email protected]>
Signed-off-by: srikant <[email protected]>
Signed-off-by: srikant <[email protected]>
Signed-off-by: srikant <[email protected]>
| @@ -234,6 +234,8 @@ class RadiosetControl extends React.Component { | |||
| orientation={this.props.control.orientation} | |||
| helperText={this.props.control.helperText} | |||
| readOnly={this.props.readOnly} | |||
| // Provide unique aria-label for each radio button group | |||
| aria-label={`Radio Button Group (${ControlUtils.getDataId(this.props.control, this.props.propertyId)})`} | |||
There was a problem hiding this comment.
Shouldn't this be translated?
srikant-ch5
changed the title
Signed-off-by: srikant <[email protected]>
Signed-off-by: srikant <[email protected]>
Signed-off-by: srikant <[email protected]>
srikant-ch5
changed the title
Signed-off-by: srikant <[email protected]>
matthoward366
requested changes
Jan 22, 2025
| @@ -234,6 +237,8 @@ class RadiosetControl extends React.Component { | |||
| orientation={this.props.control.orientation} | |||
| helperText={this.props.control.helperText} | |||
| readOnly={this.props.readOnly} | |||
| // Provide unique aria-label for each radio button group | |||
| aria-label={`${radioBtnGroupAriaLabel} (${ControlUtils.getDataId(this.props.control, this.props.propertyId)})`} | |||
There was a problem hiding this comment.
Seems odd have the dataId in the text. Is there a reason for that?
| @@ -123,6 +124,7 @@ TableButtons.propTypes = { | |||
| propertyId: PropTypes.object.isRequired, | |||
| customButtons: PropTypes.array.isRequired, | |||
| tableState: PropTypes.string, | |||
| toolbarOverflowLabel: PropTypes.string, | |||
There was a problem hiding this comment.
Why does this need to be passed in as a prop? Does this show up in the UI or is it only an aria-label?
| @@ -95,6 +95,8 @@ | |||
| "table.toolbar.button.delete": "Delete", | |||
| "table.toolbar.button.edit": "Edit", | |||
| "table.toolbar.button.cancel": "Cancel", | |||
| "table.toolbar.overflow.label": "Table Toolbar Overflow", | |||
There was a problem hiding this comment.
These should be sentence case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2294
Developer's Certificate of Origin 1.1