Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Update build and create NPM package [ED-7724] #70

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
name: Node CI
matipojo marked this conversation as resolved.
Show resolved Hide resolved

on:
pull_request:
push:
branches: [master]

jobs:
build:
runs-on: ubuntu-latest

strategy:
matrix:
node-version: [16.x]
matipojo marked this conversation as resolved.
Show resolved Hide resolved

steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- name: Install Dependencies
run: npm ci
- name: Build
run: npm run build
66 changes: 66 additions & 0 deletions .github/workflows/prerelease.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
name: pre-release
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure we want this pre-release action on a public repository. everyone will be able to publish new packages, doesnt make much sense.
we need the pre-release appraoch as Manual action that will be executed on demand by developers

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: 0db1e5c


on:
issue_comment:
types: [created]

jobs:
pre-release:
if: contains(github.event.comment.body, 'prerelease')
runs-on: ubuntu-latest

strategy:
matrix:
node-version: [16.x]

steps:
- uses: actions/github-script@v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are using many versions of this action (0.3.0, v1, v4) is there a reason for it? If so, please explain in code in comments.

Copy link
Member Author

@yotamselementor yotamselementor Jul 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prerelease/release scripts should be reviewed/rewritten by @chenele & her team

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenele can you take a look?

yotamselementor marked this conversation as resolved.
Show resolved Hide resolved
id: pr
with:
result-encoding: string
script: |
return github.pulls.get({
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: context.payload.issue.number
}).then( (pr) => { return pr.data.head.ref })
- name: React to comment
uses: actions/github-script@v4
yotamselementor marked this conversation as resolved.
Show resolved Hide resolved
with:
script: |
const {owner, repo} = context.issue
github.reactions.createForIssueComment({
owner,
repo,
comment_id: context.payload.comment.id,
content: "eyes",
});
- uses: actions/checkout@v3
with:
fetch-depth: 0
ref: ${{ steps.pr.outputs.result }}
- name: Get Latest Tag
run: echo "LATEST_TAG=$(git tag '--sort=version:refname'| tail -1 | awk '{ print } END { if (!NR) print "0.0.0" }')" >> $GITHUB_ENV
- name: Calculate version
run: |
export BRANCH=$(echo ${{steps.pr.outputs.result}} | sed 's/_/-/g' | cut -d- -f2)
export COMMIT=$(git rev-parse --short HEAD)
echo "VERSION=${BRANCH}-${COMMIT}" >> $GITHUB_ENV
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
registry-url: https://npm.pkg.github.com/
scope: ${{ github.repository_owner }}
- run: npm install
- run: npm ci
- run: npm version ${{ env.LATEST_TAG }}-${{ env.VERSION }} --no-git-tag-version
- run: npm publish
env:
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: 'Comment PR'
uses: actions/[email protected]
yotamselementor marked this conversation as resolved.
Show resolved Hide resolved
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
const { issue: { number: issue_number }, repo: { owner, repo } } = context;
github.issues.createComment({ issue_number, owner, repo, body: 'done, package version: ${{ env.LATEST_TAG }}-${{ env.VERSION }}' });
29 changes: 29 additions & 0 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: publish

on:
release:
types: [published]

jobs:
publish:
runs-on: ubuntu-latest

strategy:
matrix:
node-version: [16.x]

steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
registry-url: https://npm.pkg.github.com/
scope: ${{ github.repository_owner }}
- run: npm install
- run: npm ci
- run: npm version ${{ github.event.release.tag_name }} --no-git-tag-version
- run: npm publish
env:
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
33 changes: 33 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: Release

on:
pull_request:
types: [ closed ]

jobs:
release:
if: github.event.pull_request.merged == true && github.base_ref == 'master' && !contains(github.event.pull_request.labels.*.name, 'skip release')
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Get Latest Tag
run: echo "LATEST_TAG=$(git tag '--sort=version:refname'| tail -1 | awk '{ print } END { if (!NR) print "0.0.0" }')" >> $GITHUB_ENV
- name: Increment Tag
uses: actions-ecosystem/action-bump-semver@v1
id: bump-semver
with:
current_version: ${{ env.LATEST_TAG }}
level: patch
- name: Create Release
id: create_release
uses: actions/create-release@latest
env:
GITHUB_TOKEN: ${{ secrets.CLOUD_DEVOPS_TOKEN }}
with:
tag_name: ${{ steps.bump-semver.outputs.new_version }}
release_name: "${{ steps.bump-semver.outputs.new_version }}: ${{ github.event.pull_request.title }}"
draft: false
prerelease: false
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,9 @@ composer.lock
Thumbs.db
yarn.lock

# Generated code
css
eicons.json

*.log
*.map
124 changes: 0 additions & 124 deletions Gruntfile.js

This file was deleted.

2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
### Elementor Icons ###

Repo for [Elementor](https://github.com/pojome/elementor) Icons
Repo for [Elementor](https://github.com/elementor/elementor) Icons

See it in action: [Icons Demo](https://elementor.github.io/elementor-icons/)

Expand Down
Loading