Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Update build and create NPM package [ED-7724] #70

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

yotamselementor
Copy link
Member

@yotamselementor yotamselementor commented Jul 17, 2022

This PR does the following:

  • Updates the build process to stop using Grunt
  • Updates the node modules
  • Creates a node module as the output of the build process instead of storing the build results in Git
  • No longer adds a banner to the minified CSS file since we now get the version from the node module

@yotamselementor yotamselementor changed the title Build Update build and create NPM package Jul 17, 2022
@yotamselementor yotamselementor changed the title Update build and create NPM package Internal: Update build and create NPM package [ED-7724] Jul 17, 2022
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
node-version: [16.x]

steps:
- uses: actions/github-script@v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are using many versions of this action (0.3.0, v1, v4) is there a reason for it? If so, please explain in code in comments.

Copy link
Member Author

@yotamselementor yotamselementor Jul 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prerelease/release scripts should be reviewed/rewritten by @chenele & her team

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenele can you take a look?

package.json Outdated Show resolved Hide resolved
scripts/postcss.mjs Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@@ -0,0 +1,66 @@
name: pre-release
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure we want this pre-release action on a public repository. everyone will be able to publish new packages, doesnt make much sense.
we need the pre-release appraoch as Manual action that will be executed on demand by developers

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: 0db1e5c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants