-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal: Update build and create NPM package [ED-7724] #70
base: master
Are you sure you want to change the base?
Conversation
.github/workflows/prerelease.yml
Outdated
node-version: [16.x] | ||
|
||
steps: | ||
- uses: actions/github-script@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are using many versions of this action (0.3.0, v1, v4) is there a reason for it? If so, please explain in code in comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The prerelease/release scripts should be reviewed/rewritten by @chenele & her team
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chenele can you take a look?
Co-authored-by: chenele <[email protected]>
Co-authored-by: chenele <[email protected]>
Co-authored-by: chenele <[email protected]>
.github/workflows/prerelease.yml
Outdated
@@ -0,0 +1,66 @@ | |||
name: pre-release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure we want this pre-release action on a public repository. everyone will be able to publish new packages, doesnt make much sense.
we need the pre-release appraoch as Manual action that will be executed on demand by developers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: 0db1e5c
This PR does the following: