Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AttachmentsState and use the MessagesNavigator #3918

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Remove AttachmentsState and use the MessagesNavigator #3918

merged 5 commits into from
Nov 21, 2024

Commits on Nov 21, 2024

  1. Remove AttachmentsState and use the MessagesNavigator

    @bmarty
    bmarty committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    4e840b9 View commit details
    Browse the repository at this point in the history

  2. No need to have @SingleIn(RoomScope::class) for this presenter.

    @bmarty
    bmarty committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    cd645ee View commit details
    Browse the repository at this point in the history

  3. Improve FakeMessagesNavigator using lambda as per the new test system.

    @bmarty
    bmarty committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    7421f0f View commit details
    Browse the repository at this point in the history

  4. Let the TimelinePresenter.Factory be injected in MessagesNode to have… 

    … a better architecture of dependencies between presenter.
    @bmarty
    bmarty committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    48b82d2 View commit details
    Browse the repository at this point in the history

  5. Cleanup

    @bmarty
    bmarty committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    28d701a View commit details
    Browse the repository at this point in the history