-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove AttachmentsState and use the MessagesNavigator #3918
Conversation
… a better architecture of dependencies between presenter.
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3918 +/- ##
===========================================
+ Coverage 82.95% 82.96% +0.01%
===========================================
Files 1786 1786
Lines 45224 45198 -26
Branches 5338 5334 -4
===========================================
- Hits 37517 37500 -17
+ Misses 5836 5830 -6
+ Partials 1871 1868 -3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Remove AttachmentsState and use the MessagesNavigator.
Close #3910
Let the Node use the factories so that we have cleaner Presenter constructors.