Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AttachmentsState and use the MessagesNavigator #3918

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Nov 21, 2024

Remove AttachmentsState and use the MessagesNavigator.

Close #3910

Let the Node use the factories so that we have cleaner Presenter constructors.

@bmarty bmarty requested a review from a team as a code owner November 21, 2024 17:25
@bmarty bmarty requested review from jmartinesp and removed request for a team November 21, 2024 17:25
@bmarty bmarty added the PR-Misc For other changes label Nov 21, 2024
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/bHWBUK

Copy link

sonarcloud bot commented Nov 21, 2024

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.96%. Comparing base (e8af711) to head (28d701a).
Report is 13 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3918      +/-   ##
===========================================
+ Coverage    82.95%   82.96%   +0.01%     
===========================================
  Files         1786     1786              
  Lines        45224    45198      -26     
  Branches      5338     5334       -4     
===========================================
- Hits         37517    37500      -17     
+ Misses        5836     5830       -6     
+ Partials      1871     1868       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ganfra ganfra changed the title Navigation cleanup Remove AttachmentsState and use the MessagesNavigator Nov 21, 2024
@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 21, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 21, 2024
@bmarty bmarty merged commit 618d300 into develop Nov 21, 2024
33 checks passed
@bmarty bmarty deleted the feature/bma/navigationCleanup branch November 21, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove AttachmentsState and use the MessagesNavigator
2 participants