-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable all notification actions: quick reply, accept/decline invite, mark as read from notification. #3916
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3916 +/- ##
===========================================
+ Coverage 82.92% 83.04% +0.11%
===========================================
Files 1785 1785
Lines 45178 45214 +36
Branches 5331 5331
===========================================
+ Hits 37464 37546 +82
+ Misses 5843 5796 -47
- Partials 1871 1872 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM, thanks!
Love it! Thanks Benoit. My only tiny suggestion is to change the button copy to 'accept' and 'decline' for invite notifications to match the actions within the app. :) |
Quality Gate passedIssues Measures |
Content
Enable all notification actions: quick reply, accept/decline invite, mark as read from notification.
Motivation and context
Closes #3908
Closes #1966
Screenshots / GIFs
Tests
Tested devices
Checklist