Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable all notification actions: quick reply, accept/decline invite, mark as read from notification. #3916

Merged
merged 7 commits into from
Nov 26, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Nov 21, 2024

Content

Enable all notification actions: quick reply, accept/decline invite, mark as read from notification.

Motivation and context

Closes #3908
Closes #1966

Screenshots / GIFs

Notification action

Tests

  • Receive notification for message or for room invite and see that they now have actions.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty added the PR-Feature For a new feature label Nov 21, 2024
@bmarty bmarty requested a review from a team as a code owner November 21, 2024 13:59
@bmarty bmarty requested review from jmartinesp and removed request for a team November 21, 2024 13:59
Copy link
Contributor

github-actions bot commented Nov 21, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/5Yqk8M

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.04%. Comparing base (ee50b50) to head (b271dc5).
Report is 85 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3916      +/-   ##
===========================================
+ Coverage    82.92%   83.04%   +0.11%     
===========================================
  Files         1785     1785              
  Lines        45178    45214      +36     
  Branches      5331     5331              
===========================================
+ Hits         37464    37546      +82     
+ Misses        5843     5796      -47     
- Partials      1871     1872       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM, thanks!

@amshakal
Copy link

Love it! Thanks Benoit. My only tiny suggestion is to change the button copy to 'accept' and 'decline' for invite notifications to match the actions within the app. :)

Copy link

sonarcloud bot commented Nov 22, 2024

@bmarty bmarty merged commit 8d26af5 into develop Nov 26, 2024
25 checks passed
@bmarty bmarty deleted the feature/bma/notificationActions branch November 26, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Feature For a new feature
Projects
None yet
3 participants