Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications aren't set as Conversation #1547

Open
RoiArthurB opened this issue Oct 11, 2023 · 9 comments
Open

Notifications aren't set as Conversation #1547

RoiArthurB opened this issue Oct 11, 2023 · 9 comments
Labels
A-Notifications O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Product Issue needs input from Product team

Comments

@RoiArthurB
Copy link

Steps to reproduce

  1. Receive a notification
  2. See it as random notification instead of Conversation

Here's a screenshot displaying difference notification between old Element and Element X :

1000008161

Outcome

What did you expect?

To have enriched notifications labeled and grouped in Android 13 as a conversation notification and have quick options as "Mark as read" or "Quick Reply"

What happened instead?

Normal blank notification (see screenshot above)

Possible cause

I didn't see any issue about this, so I'm guessing it can be because of my phone configuration. I'm using a de-googled smartphone running MicroG instead of Google Play Service 🤷

Your phone model

Poco F3

Operating system version

Android 13

Application version and app store

Element X 0.2.3

Homeserver

matrix-org/synapse:v1.93.0

Will you send logs?

No

Are you willing to provide a PR?

No

@RoiArthurB RoiArthurB added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Oct 11, 2023
@julioromano julioromano added A-Notifications S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Oct 13, 2023
@dkter
Copy link

dkter commented Oct 13, 2023

On a quick glance, notification logic seems to be lifted from the old app -- so all that's fine.

What's missing are shortcuts (the links to specific rooms that pop up when you long press an app icon on the home screen, or that show at the top of a share sheet). Android won't put a notification in the conversations section if it's not associated with a shortcut.

Once those are created, conversation features should work fine. Here's how shortcut creation was handled in the old app.

@RoiArthurB
Copy link
Author

@dkter I checked the code and yes it seems weird that it's missing enriched and well classified notifications... Do you have the same issue as me ?

@dkter
Copy link

dkter commented Oct 16, 2023

Yep, I have the same issue, it's not because of your configuration @RoiArthurB.

I started taking a look at what would be required to implement shortcut publishing in this app, but may not have time to finish it anytime soon.

@kittykat kittykat added X-Needs-Product Issue needs input from Product team Z-Schedule labels Oct 19, 2023
@kittykat kittykat added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements and removed T-Defect Something isn't working: bugs, crashes, hangs and other reported problems labels Nov 23, 2023
@Soliprem
Copy link

Any news on this?

@slackerbob
Copy link

This is the main thing that's stopping me from using Element X instead of Element.

@cliffjao
Copy link

Seems like this might have been resolved with #3916 ?

@codesalatdev
Copy link

codesalatdev commented Nov 29, 2024

Seems like this might have been resolved with #3916 ?

I can see that this PR adds actions to notifications, but I don't see any reference to the conversation API, which would enable one to exclude certain chats from "Do not Disturb"-Mode and assign different notification sounds, among other things.
Will have to test tho as I have no clue about android development.

@damymetzke
Copy link

I can see that this PR adds actions to notifications, but I don't see any reference to the conversation API, which would enable one to exclude certain chats from "Do not Disturb"-Mode and assign different notification sounds, among other things. Will have to test tho as I have no clue about android development.

There is no "conversation API". There is an initiative from the Android team to integrate conversation better with the OS. See https://developer.android.com/develop/ui/views/notifications/conversations for more information.

In my opinion the feature as it's explained here is implemented in #3916. I'd say it's appropriate to create a new issue, if you think implementing any other conversation-related API is beneficial.

@codesalatdev
Copy link

In my opinion the feature as it's explained here is implemented in #3916. I'd say it's appropriate to create a new issue, if you think implementing any other conversation-related API is beneficial.

Since #2992 discussed the features I am describing and was closed as a duplicate of this issue, I'd disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Product Issue needs input from Product team
Projects
None yet
Development

No branches or pull requests

10 participants