Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With osm #18

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

With osm #18

wants to merge 32 commits into from

Conversation

RichardHitier
Copy link

Hi, this PR is for adding OpenStreetMap support on this addon.

Richard Hitier added 30 commits April 8, 2018 18:31
allowMultiple was always true.

We now return 1 or 0 depending on the boolean state of the
inputsettings combo.
If this var on, we insert new file.tpl so to show OSM
background.
The clear button wouldnt work properly.
Setting markers table global,
using the removeMarker at beggingin of initMap() does the
trick.
Didnt work with real https site.
About to change for new url.
Osm tv feature is activated with the geotv.allow_osm
parameter.

This commit adds the automatic creation of that param to the
build scirpt so it is created (default true) at extension
installation.
Previously stored in an array,

New FeatureGroug now allows:

- easy conversion in modx format (featureGroup2Data() )
- easy erasing all at once (removeMarkers() )
- fixing point dragging not saved
@Spheerys
Copy link
Contributor

@electrickite Can you please accept this PR ?
Your add-on is still working like a charm under MODX 3 and I'm using it regulary, once or twice a year for new projects.
If you don't want to manage this add-on anymore, can you please transfer the ownership to make improvements profitable for everyone ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants