-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
With osm #18
Open
RichardHitier
wants to merge
32
commits into
electrickite:master
Choose a base branch
from
RichardHitier:WithOsm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
With osm #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allowMultiple was always true. We now return 1 or 0 depending on the boolean state of the inputsettings combo.
If this var on, we insert new file.tpl so to show OSM background.
The clear button wouldnt work properly. Setting markers table global, using the removeMarker at beggingin of initMap() does the trick.
Didnt work with real https site. About to change for new url.
Osm tv feature is activated with the geotv.allow_osm parameter. This commit adds the automatic creation of that param to the build scirpt so it is created (default true) at extension installation.
Previously stored in an array, New FeatureGroug now allows: - easy conversion in modx format (featureGroup2Data() ) - easy erasing all at once (removeMarkers() ) - fixing point dragging not saved
@electrickite Can you please accept this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR is for adding OpenStreetMap support on this addon.