-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion : add OpenStreeMap as map engine #4
Comments
I don't have any fundamental problems using OSM. I'm personally not as experienced with their API, so Google is my go-to choice. Does OSM provide the same drawing features (polygons, etc) as the Google Maps API? |
I think yes, but I'm not an expert with the OSM API. |
If OSM were implemented as a mapping provider, Google Maps should remain available as an option. Some locations have better coverage through Google. It's also my understanding that in some countries (notably China) using crowd-sourced mapping data like OSM is illegal. |
Yes of course : we plan to try to implement OSM on GeoTV as an option next weeks. I think an option on TV parameters to choose between GMaps and OSM very nice. |
What is the best way to develop the OSM support ? We make another branch on our cloned repository and we replace the GMaps API calls ? |
Yes, working on a separate feature branch would be a good idea. The best approach might be to re-write the point and area drawing interface using something like Leaflet.js. Then use OSM or Google to provide the tile sets. Something similar to this: https://github.com/shramov/leaflet-plugins/blob/master/examples/google.html |
Hi, I'm currently working on the OSM rewriting. thanks. |
A little up because we are blocked with Richard. |
A pull request is on the way :) |
Here it is : #18 Once merged and upgraded on MODX, you have to change the key setting geotv.enable_osm to enable. |
Hello @electrickite :) Can you please take a look to our job, and evently ask question or say something about the OSM option ? |
I'm a contributor to OSM mapping and I prefer to use OSM for mapping activities : it's generaly more precise, and I don't like Google anymore :)
Maybe it's a big deal to implement OSM on GeoTV, but if it's not, that's my suggestion for a future release : make an option during GeoTV installation or on a system key to choose which mapper we want :)
The text was updated successfully, but these errors were encountered: