Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion : add OpenStreeMap as map engine #4

Open
Spheerys opened this issue Jan 19, 2016 · 11 comments
Open

Suggestion : add OpenStreeMap as map engine #4

Spheerys opened this issue Jan 19, 2016 · 11 comments

Comments

@Spheerys
Copy link
Contributor

I'm a contributor to OSM mapping and I prefer to use OSM for mapping activities : it's generaly more precise, and I don't like Google anymore :)
Maybe it's a big deal to implement OSM on GeoTV, but if it's not, that's my suggestion for a future release : make an option during GeoTV installation or on a system key to choose which mapper we want :)

@Spheerys Spheerys changed the title Suggestion : use OpenStreeMap as map engine Suggestion : add OpenStreeMap as map engine Jan 19, 2016
@electrickite
Copy link
Owner

I don't have any fundamental problems using OSM. I'm personally not as experienced with their API, so Google is my go-to choice. Does OSM provide the same drawing features (polygons, etc) as the Google Maps API?

@Spheerys
Copy link
Contributor Author

I think yes, but I'm not an expert with the OSM API.
In fact, I can also ask a friend to have a look on this point :)

@electrickite
Copy link
Owner

If OSM were implemented as a mapping provider, Google Maps should remain available as an option. Some locations have better coverage through Google. It's also my understanding that in some countries (notably China) using crowd-sourced mapping data like OSM is illegal.

@Spheerys
Copy link
Contributor Author

Yes of course : we plan to try to implement OSM on GeoTV as an option next weeks.
At minimum a working principe.
In my aera, GMaps is very poor and I also do my best to avoid using Google tools :)

I think an option on TV parameters to choose between GMaps and OSM very nice.

@Spheerys
Copy link
Contributor Author

What is the best way to develop the OSM support ? We make another branch on our cloned repository and we replace the GMaps API calls ?

@electrickite
Copy link
Owner

Yes, working on a separate feature branch would be a good idea.

The best approach might be to re-write the point and area drawing interface using something like Leaflet.js. Then use OSM or Google to provide the tile sets.

Something similar to this: https://github.com/shramov/leaflet-plugins/blob/master/examples/google.html

@RichardHitier
Copy link

Hi, I'm currently working on the OSM rewriting.
But I 'm still stuck on one point: allowMultiple is always set to 1 even if i set it to 'No' in the "input option" page.
any clue appreciated :-)

thanks.

@Spheerys
Copy link
Contributor Author

Spheerys commented Feb 8, 2016

A little up because we are blocked with Richard.
But maybe we have to open a new issue for this specific problem ?

@Spheerys
Copy link
Contributor Author

A pull request is on the way :)

@Spheerys
Copy link
Contributor Author

Spheerys commented Jun 15, 2018

Here it is : #18
Thanks Richard !!

Once merged and upgraded on MODX, you have to change the key setting geotv.enable_osm to enable.
You can still use GMaps by setting it to disabled.

@Spheerys
Copy link
Contributor Author

Spheerys commented Aug 5, 2019

Hello @electrickite :)

Can you please take a look to our job, and evently ask question or say something about the OSM option ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants