Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add license to bash script #37

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Conversation

aspacca
Copy link
Contributor

@aspacca aspacca commented Nov 24, 2021

No description provided.

@aspacca aspacca requested a review from endorama November 24, 2021 15:55
@aspacca aspacca self-assigned this Nov 24, 2021
@aspacca aspacca removed the request for review from endorama November 24, 2021 16:04
@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 18 min 30 sec

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@endorama
Copy link
Member

I'd like to suggest an alternative: https://github.com/elastic/go-licenser

Is the tool in use in beats and I think would be a better choice in the long run.

@aspacca
Copy link
Contributor Author

aspacca commented Nov 24, 2021

@endorama when I created the project https://github.com/elastic/go-licenser didn't support Elastic 2.0, that's the reason I wrote an ad hoc script

I see now it supports it, but It still has the problem that it puts the license before the shebang in bash :(

@endorama
Copy link
Member

Looking at go-licenser source it clearly does not support anything that is not Go code, so this solutions works for me. Meanwhile I opened an issue to discuss possible expansion of file support.

@aspacca aspacca merged commit 9165a3f into elastic:main Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants