Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-go source files specifics #43

Open
endorama opened this issue Nov 25, 2021 · 2 comments
Open

Support non-go source files specifics #43

endorama opened this issue Nov 25, 2021 · 2 comments

Comments

@endorama
Copy link
Member

Working on a different application adding license's header to files was needed.

I suggested the use of go-licenser, but due to the current implementation it was not possible for that repo.

For that use case is required to add files to BASH and Python files, which is not working correctly (probably works for Python but cannot work for BASH).

In the case of BASH the shebang (#!/bin/sh) must be preserved as first line and // is not a valid comment starter.

Reading through the code of licensing seems clear that this tools is lacking on support of source files different from Go.

Would you advise to contribute support to the project or is out of scope? I think there is value in adding support for other languages allowing for customization on a language basis; that would make this tool more generic and in the long run ease adoption.

Thanks!

@simitt
Copy link

simitt commented Jun 3, 2022

+1 on supporting non-go sourcefiles. The ext param suggest it is supported, but e.g. python and js specificas are ignored, leading to invalid files.

@AlexanderWert
Copy link
Member

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants