Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed version of Docker build context #172

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Fixed version of Docker build context #172

merged 1 commit into from
Apr 4, 2024

Conversation

robbavey
Copy link
Member

@robbavey robbavey commented Apr 3, 2024

Works around lack of $TARGETARCH variable in Docker build scripts
Generated using changes from elastic/logstash#16053

Works around lack of $TARGETARCH variable in Docker build scripts
Generated using changes from elastic/logstash#16053
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the Logstash side this LGTM. I tested this PR locally: building and running the images for both architectures, and it works correctly.

@navyau09 navyau09 merged commit 4fdbd17 into 8.13 Apr 4, 2024
1 check passed
@jmlrt jmlrt deleted the manual_dockerfile branch December 16, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants