Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12] Add initial CI workflows #18

Merged
merged 8 commits into from
Dec 16, 2024
Merged

Conversation

orecham
Copy link
Contributor

@orecham orecham commented Dec 10, 2024

Notes for Reviewer

WIP.

Add CI checks for:

  1. Issue number in commit message
  2. Presence of copyright header
  3. Violations in clang-format and clang-tidy
    1. clang-tidy violations moved to: Fix clang-tidy violations #19
  4. Passing clang build
  5. Passing unit tests

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Relevant issues are linked in the References section
  • Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  • Branch follows the naming format (rmw-iox2-123-implement-graph-api)
  • Commit messages have the issue ID ([#123] Add posix ipc example)
  • Tests exist for new behavior
  • Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Relates #12

@orecham orecham changed the title [#12] Make CI scripts executable [#12] Add initial CI workflows Dec 10, 2024
@elBoberido
Copy link

@orecham I think you either need to move the scripts to the internal folder or remove internal from the path in the workflow file.

@orecham orecham force-pushed the rmw-iox2-12-add-ci-jobs branch 2 times, most recently from 8159fba to 7ec081c Compare December 11, 2024 06:11
@orecham orecham force-pushed the rmw-iox2-12-add-ci-jobs branch from 9d1bdce to 4cfccc7 Compare December 14, 2024 20:19
@orecham orecham self-assigned this Dec 14, 2024
@orecham orecham force-pushed the rmw-iox2-12-add-ci-jobs branch from b6fbb90 to d2e994d Compare December 16, 2024 01:16
@orecham orecham force-pushed the rmw-iox2-12-add-ci-jobs branch from 06380cc to 855adcb Compare December 16, 2024 01:34
@orecham orecham merged commit df91999 into ekxide:main Dec 16, 2024
4 checks passed
@orecham orecham deleted the rmw-iox2-12-add-ci-jobs branch December 19, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants