Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: michaelortmann
Patch by: michaelortmann
Fixes: #627
One-line summary:
Add -d (Show debug info) command line argument and fix putlog() to respect conmask.
Additional description (if needed):
Eggdrop reads console setting with log levels from config file.
But it is using putlog() with LOG_DEBUG before reading it.
There was no way to dynamically tell eggdrop, when LOG_DEBUG is wanted and when not for this early startup period.
So it was a static setting in eggdrop effectively disabling LOG_DEBUG until config file is read.
Because the early startup period was buggy regarding logging, another bug found its way into then code: putlog() did not respect conmask.
This PR adds -d (Show debug info) command line argument and fixes putlog() to respect conmask.
Test cases demonstrating functionality (if applicable):
Test 1 - BotA.conf console setting without d
Before:
After:
Test 2 - BotA.conf console setting with d
Before:
After: