Update inet_aton.c from FreeBSD uptream removes advertising clause #967
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: michaelortmann
Patch by: michaelortmann
Fixes:
One-line summary:
The new https://github.com/freebsd/freebsd/blob/455de2f90f71a495eb5068b060c17de9bfcffda6/lib/libc/inet/inet_addr.c removes advertising clause from license.
Additional description (if needed):
The only user of inet_aton() within eggdrop is one function in dns module. I tested this function and enhanced its logging. But you cant see the
DNS: Valid dns-server
message, because #948 is not merged yet. egg_inet_aton() now uses isdigit(), islower(), isspace() instead of egg_*() due to all of them being posix 2001.Removal of the advertising clause helps with #226 see #226 (comment)_
Test cases demonstrating functionality (if applicable):