Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert encoding of language files to utf-8 #1661

Merged
merged 4 commits into from
Jul 30, 2024
Merged

Convert encoding of language files to utf-8 #1661

merged 4 commits into from
Jul 30, 2024

Conversation

thommey
Copy link
Member

@thommey thommey commented Jul 29, 2024

Italian and Portuguese were already added as UTF-8.
German and English are ASCII (German allows replacing ä with ae etc.).
French, Finnish and Danish are converted explicitely with this PR.

Blocked by #1526 (needs to be done again after merging it).

Found by: Geo
Patch by: thommey

One-line summary: Convert encoding of french, finnish and danish language file to utf-8

Conversion done with iconv -f iso8859-1 -t utf-8

@thommey thommey marked this pull request as draft July 29, 2024 16:30
@thommey thommey marked this pull request as ready for review July 29, 2024 17:16
Copy link
Member

@skralg skralg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to assume iconv did these right. Spot checks look proper to me.

@vanosg vanosg added this to the v1.10.0 milestone Jul 30, 2024
@vanosg vanosg merged commit e09ed19 into develop Jul 30, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants