Remove copy-to-tmp option #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelortmann
changed the title
|
Sorry if there was confusion- the default should be 0. We need to change (or maybe just start over?) on this and change logic to assume a 1, not a 0. |
michaelortmann
changed the title
michaelortmann
changed the title
|
Ready for review again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: Geo
Patch by: michaelortmann
Fixes: #1503
One-line summary:
Remove
copy-to-tmpoptionAdditional description (if needed):
New behaviour is old default
copy-to-tmp == 1Leave module API as is with
copy-to-tmpset to1For eggdrop 2.0 remaining bits of
copy-to-tmpshould be removed from module APIPlease run
misc/generatedocsafter merge.Test cases demonstrating functionality (if applicable):
a small regression test with linking 2 share bots succeeded, the userfile was transferred.