fix: replace username with full name in attemp emails #250
Conversation
edx_exams/apps/core/email.py
Outdated
| @@ -44,12 +44,13 @@ def send_attempt_status_email(attempt, escalation_email=None): | |||
| contact_url = f'{settings.LMS_ROOT_URL}/support/contact_us' | |||
| contact_url_text = contact_url | |||
|
|
|||
| email_subject = f'Proctored exam {exam.exam_name} for user {attempt.user.username}' | |||
| email_subject = f'Proctored exam {exam.exam_name} for user {attempt.user.full_name}' | |||
There was a problem hiding this comment.
AFAIK this IDA isn't populating full_name when it creates new User objects since up until this point there's been no use for it. I think you'll need to ensure that happens and possibly migrate that value into existing users.
There was a problem hiding this comment.
Can you share how data is populated in this IDA?
There was a problem hiding this comment.
I'm not exactly sure, it's part of the cookie cutter installation for all IDAs. I think it's baked into JWT authentication within https://github.com/openedx/edx-drf-extensions somehow. Although, I imagine this could be an issue for all other IDAs as well depending on if the particular bit of code is looking at JWT details vs the User object from the database. Names should be on the JWT but doesn't seem to always exist in the User model.
ahtesham-quraish
force-pushed
the
ahtesham/1833
branch
3 times, most recently
from
e46f853 to
aafadce
Compare
ahtesham-quraish
force-pushed
the
ahtesham/1833
branch
from
aafadce to
f15af7e
Compare
ahtesham-quraish
force-pushed
the
ahtesham/1833
branch
from
f15af7e to
b2deb6b
Compare
I made the change now |
ahtesham-quraish
force-pushed
the
ahtesham/1833
branch
from
b2deb6b to
ccfbbe3
Compare
Description: Remove username and change the subject of emails VAN-1833
ahtesham-quraish
force-pushed
the
ahtesham/1833
branch
from
ccfbbe3 to
d4122fc
Compare
| @@ -44,7 +47,6 @@ def send_attempt_status_email(attempt, escalation_email=None): | |||
| contact_url = f'{settings.LMS_ROOT_URL}/support/contact_us' | |||
| contact_url_text = contact_url | |||
|
|
|||
| email_subject = f'Proctored exam {exam.exam_name} for user {attempt.user.username}' | |||
There was a problem hiding this comment.
Why can we not leave the exam name in?
There was a problem hiding this comment.
Actually we have discussed subject line with UX team and they suggested us that we can remove the exam name from subject but if you still think we should get it back we can then discuss with UX again. Thanks
ahtesham-quraish
dismissed
zacharis278’s stale review
We already got 3 approval so no need to get any another
JIRA:
VAN-1833
Description:
Remove username and change subject in attempts emails
Testing instructions:
It has been tested locally