fix: remove username and change the subject in emails #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahtesham-quraish
force-pushed
the
ahtesham/1865
branch
9 times, most recently
from
163d2fe to
5b88ccb
Compare
alangsto
requested changes
Mar 14, 2024
| exam_name=exam_attempt_obj.proctored_exam.exam_name | ||
| ) | ||
| ) | ||
| email_subject = 'Proctoring attempt submitted' |
There was a problem hiding this comment.
This email subject didn't contain the username, is there a reason we shouldn't be using the course name or exam name?
There was a problem hiding this comment.
We have removed the exam name along with username to make it consistent with edx-exams. We already took consensus from UX team to change the subject line.
edx_proctoring/api.py
Outdated
| @@ -1767,7 +1764,7 @@ def create_proctoring_attempt_status_email(user_id, exam_attempt_obj, course_nam | |||
| course_home_url = get_course_home_url(exam_attempt_obj.proctored_exam.course_id) | |||
|
|
|||
| exam_name = exam_attempt_obj.proctored_exam.exam_name | |||
| support_email_subject = _('Proctored exam {exam_name} in {course_name} for user {username}').format( | |||
| support_email_subject = _('Proctored exam {exam_name} in {course_name}').format( | |||
There was a problem hiding this comment.
If this isn't being used in the template, can it just be removed?
There was a problem hiding this comment.
Yes we can remove this.
ahtesham-quraish
force-pushed
the
ahtesham/1865
branch
3 times, most recently
from
3878259 to
41e52c7
Compare
Description: Remove username and change the subject in emails VAN-1865
ahtesham-quraish
force-pushed
the
ahtesham/1865
branch
from
41e52c7 to
9d4eb5d
Compare
alangsto
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove username from email templates and change the subject line
JIRA:
VAN-1865