feat: add proctorio redirect url #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharis278
commented
Dec 15, 2023
| @@ -235,12 +235,12 @@ def start_proctoring(request, attempt_id): | |||
| lti_config = LtiConfiguration.objects.get(id=lti_config_id) | |||
|
|
|||
| proctoring_start_assessment_url = urljoin( | |||
| get_lti_root(), | |||
| get_lti_api_base(), | |||
There was a problem hiding this comment.
this helper function already existed in the lti library. Removed a 'duplicate' util from this service
zacharis278
commented
Dec 15, 2023
| @@ -61,7 +61,10 @@ class ExamAttemptAdmin(admin.ModelAdmin): | |||
|
|
|||
| def change_view(self, request, object_id, form_url='', extra_context=None): | |||
| extra_context = extra_context or {} | |||
| extra_context['LTI_ROOT'] = get_lti_root() | |||
| # technically this should be be using get_lti_view_base() but the | |||
There was a problem hiding this comment.
the customization on this django view can eventually be removed. It was only needed when we didn't have a UI to test with. I didn't want to add all that to this PR tho
zacharis278
force-pushed
the
zhancock/custom-exam-url
branch
from
7fe9a94 to
97db843
Compare
zacharis278
force-pushed
the
zhancock/custom-exam-url
branch
from
97db843 to
6214b45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: COSMO-105
Description:
custom_urlrepresents the url seen in the browser during an exam. When the extension is installed navigating to this URL will activate it and iframe in the exam content. By using a url we own we can handle what happens when the extension is not installed since the GET to /browser_lock will hit this service. If that happens we redirect the learner to getproctorio.com to install the extension.The downside of this approach is getproctorio.com can't send the user back into the exam since we don't own that page. The learner would need to manually navigate back the the section and click start system check again.
To make this flow a bit smoother we would prefer learners download the extension first, before ever clicking 'start system check'. This ticket COSMO-130 adds that instruction to the interstitial. If they miss or ignore that instruction this PR will redirect them on the download page either way.
Note: We enforce the domain of messages from the extension. That will need to update along with this openedx/frontend-lib-special-exams#126