feat: change proctorio redirect to static page #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharis278
force-pushed
the
zhancock/proc-redirect-page
branch
from
c8771cf to
bc57c8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #227 which didn't work.
Problem
The request I thought was getting blocked/replaced by the extension still goes through and because it's a 302 response it hijacks the whole page and redirects before the extension can launch. The result is you get stuck redirecting to getproctorio.com always and can't enter the exam.
Solution
We need to use a static page and either have the learner click a link or somehow detect the extension and redirect via javascript. I'm working with Proctorio on what the best path forward would be there but this should fix the redirect problem.
Note: I added some temporary body content to this page just to see how it is or isn't rendered. It could cause some problems but there's no way to test this locally.