Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wrappers for cu/hipsparse to hic #237

Merged
merged 5 commits into from
Nov 22, 2024

Conversation

l90lpa
Copy link
Contributor

@l90lpa l90lpa commented Nov 14, 2024

This PR adds wrappers for parts of cuSparse and hipSparse to hic.

@FussyDuck
Copy link

FussyDuck commented Nov 14, 2024

CLA assistant check
All committers have signed the CLA.

@wdeconinck
Copy link
Member

Hi @l90lpa this looks great, thanks!
I would probably make hicsparse a separate cmake target though to have the choice if a downstream target will actually link with cusparse or hipsparse.

@wdeconinck
Copy link
Member

wdeconinck commented Nov 19, 2024

I rebased on latest develop and did minor changes.
I have not been able to test with HIP backend yet, as LUMI is currently offline, but I think this is now good to merge.
I will try with HIP as soon as LUMI is back, and then merge if all OK.

@l90lpa
Copy link
Contributor Author

l90lpa commented Nov 19, 2024

That all sounds great. Thanks for taking the time to review it!

@wdeconinck wdeconinck merged commit 6ec7083 into ecmwf:develop Nov 22, 2024
3 checks passed
@wdeconinck
Copy link
Member

This was tested successfully on LUMI. Thanks @l90lpa !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants