Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend sparse linear algebra interface with multiply-add #240

Merged

Conversation

l90lpa
Copy link
Contributor

@l90lpa l90lpa commented Nov 19, 2024

This PR extends Atlas's sparse linear algebra interface with multiply-add functionality.

@l90lpa l90lpa force-pushed the feature/sparse-linalg-multiply-add branch from 5a059aa to 427fc01 Compare November 20, 2024 00:27
@l90lpa
Copy link
Contributor Author

l90lpa commented Nov 20, 2024

Removed dependency on PR #237

@l90lpa
Copy link
Contributor Author

l90lpa commented Nov 21, 2024

Hi @wdeconinck, this PR currently only exposes the simple $y=Ax+y$ interface. I'm wondering if you have an actual need for $y=\alpha Ax+\beta y$ and if not whether we could leave this as follow-on action?

@wdeconinck
Copy link
Member

Thanks @l90lpa for this PR. I will review it.

Hi @wdeconinck, this PR currently only exposes the simple y = A x + y interface. I'm wondering if you have an actual need for y = α A x + β y and if not whether we could leave this as follow-on action?

Hi @l90lpa I think it's OK indeed to leave it as a follow-on action if ever needed, but as you say, unlikely.

Copy link
Member

@wdeconinck wdeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's really good and cleans up quite a nice chunk in the interpolation adjoint code path, and will improve performance! This could be merged as is a.f.a.i.c

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup with new API

@wdeconinck wdeconinck force-pushed the feature/sparse-linalg-multiply-add branch from 427fc01 to e639a06 Compare November 22, 2024 10:35
@wdeconinck wdeconinck merged commit b0203a7 into ecmwf:develop Nov 22, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants