Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the downsampling interceptor #728

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Add the downsampling interceptor #728

merged 1 commit into from
Feb 15, 2024

Conversation

sashacmc
Copy link
Member

@sashacmc sashacmc commented Feb 9, 2024 •
edited
Loading

Add the interceptor to reduce amount of sent messages based on specified filters:

  • Interfaces
  • Key expression
  • rate: maximum frequency in Hertz

@eclipse-zenoh-bot
Copy link
Contributor

@sashacmc If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

1 similar comment
@eclipse-zenoh-bot
Copy link
Contributor

@sashacmc If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

sashacmc
sashacmc commented Feb 9, 2024
View reviewed changes
zenoh/src/net/routing/interceptor/downsampling.rs Outdated Show resolved Hide resolved
zenoh/src/net/routing/interceptor/downsampling.rs Outdated Show resolved Hide resolved
zenoh/src/net/routing/mod.rs Show resolved Hide resolved
commons/zenoh-config/src/lib.rs Show resolved Hide resolved
@sashacmc sashacmc marked this pull request as ready for review February 9, 2024 10:26
@Mallets Mallets linked an issue Feb 9, 2024 that may be closed by this pull request
Interceptors configuration and attributes #663
Closed
4 tasks
@sashacmc sashacmc force-pushed the downsampling-interceptor branch 2 times, most recently from 25621ea to 560258d Compare February 9, 2024 17:20
Mallets
Mallets reviewed Feb 12, 2024
View reviewed changes
DEFAULT_CONFIG.json5 Outdated Show resolved Hide resolved
commons/zenoh-config/src/defaults.rs Outdated Show resolved Hide resolved
commons/zenoh-config/src/lib.rs Outdated Show resolved Hide resolved
@sashacmc sashacmc force-pushed the downsampling-interceptor branch 3 times, most recently from d9e75ba to 890cd61 Compare February 14, 2024 18:11
@sashacmc sashacmc force-pushed the downsampling-interceptor branch from 890cd61 to 8c39379 Compare February 14, 2024 18:16
@sashacmc sashacmc requested a review from Mallets February 14, 2024 19:20
@Mallets Mallets merged commit 078898d into eclipse-zenoh:main Feb 15, 2024
8 checks passed
@Mallets Mallets deleted the downsampling-interceptor branch February 15, 2024 08:38
@Mallets Mallets added the new feature Something new is needed label Feb 15, 2024
@Mallets Mallets added the release Part of the next release label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets approved these changes

@p-avital p-avital Awaiting requested review from p-avital

@OlivierHecart OlivierHecart Awaiting requested review from OlivierHecart

Assignees

@sashacmc sashacmc

Labels
new feature Something new is needed release Part of the next release
Projects
Zenoh 1.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interceptors configuration and attributes
5 participants
@sashacmc @eclipse-zenoh-bot @OlivierHecart @Mallets @p-avital