Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hop-to-hop compression #585

Merged
merged 36 commits into from
Nov 30, 2023
Merged

Hop-to-hop compression #585

merged 36 commits into from
Nov 30, 2023

Conversation

Mallets
Copy link
Member

@Mallets Mallets commented Nov 13, 2023

This PR introduces support for transparent hop-to-hop compression.

@Mallets Mallets added the new feature Something new is needed label Nov 13, 2023
@Mallets Mallets self-assigned this Nov 13, 2023
@Mallets Mallets marked this pull request as ready for review November 29, 2023 08:39
@Mallets
Copy link
Member Author

Mallets commented Nov 29, 2023

A synthetic performance test on this PR.

Target system:

Ubuntu 20.04 64-bit on AMD Ryzen 7 5800X 8-Core Processor

Compilation of pub/sub throughput examples

RUSTFLAGS='-C target-cpu=native' cargo build --release --example z_sub_thr --example z_pub_thr

Config stored in compression.json5:

{  transport: { unicast: { compression: { enabled: true, }, }, }, }

Running the examples (with 8 bytes payload):

RUST_LOG=debug taskset -c 1,3 ./target/release/examples/z_sub_thr -l tcp/127.0.0.1:7447 --no-multicast-scouting -n 4000000 -s 1000 -c compression.json5

and

RUST_LOG=debug taskset -c 0,2 ./target/release/examples/z_pub_thr 8 -e tcp/127.0.0.1:7447 --no-multicast-scouting -c compression.json5

Results with 8 bytes payload:

  • Compression enabled:
    • Throughput: 4.27M msg/s.
    • Batch on the wire: 290 bytes
  • Compression disabled:
    • Throughput: 4.38M msg/s
    • Batch on the wire: 65525 bytes

Results with 32K bytes payload:

  • Compression enabled:
    • Throughput: 104K msg/s.
    • Batch on the wire: 292 bytes
  • Compression disabled:
    • Throughput: 207K msg/s
    • Batch on the wire: 64025 bytes

@Mallets
Copy link
Member Author

Mallets commented Nov 29, 2023

@yellowhatter can you please review this PR?
It touches some part of the code that is also touched by #601

Copy link
Contributor

@yellowhatter yellowhatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve!

@Mallets Mallets merged commit 1dc31d4 into master Nov 30, 2023
13 of 15 checks passed
@Mallets Mallets deleted the compression branch November 30, 2023 14:29
@Mallets Mallets mentioned this pull request Nov 30, 2023
@Mallets Mallets mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Something new is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants