Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix peers start conditions bug #1477

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Fix peers start conditions bug #1477

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df40571
connect_peers returns false if not connected to avoid wrong start_con…
OlivierHecart Sep 26, 2024
24149ef
Document `connect` and `connect_peer`
fuzzypixelz Sep 27, 2024
d907ead
Clarify comments
fuzzypixelz Sep 27, 2024
0301cdc
Update comments
OlivierHecart Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion zenoh/src/net/runtime/orchestrator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -911,7 +911,7 @@ impl Runtime {
}
}

/// Returns `true` if a new Transport instance has been opened with `zid`.
/// Returns `true` if a new Transport instance exists between us and `zid`.
OlivierHecart marked this conversation as resolved.
Show resolved Hide resolved
#[must_use]
async fn connect(&self, zid: &ZenohIdProto, scouted_locators: &[Locator]) -> bool {
if !self.insert_pending_connection(*zid).await {
Expand Down Expand Up @@ -1024,6 +1024,7 @@ impl Runtime {
}
}

/// Returns `true` if a new Transport instance exists between us and `zid`.
pub async fn connect_peer(&self, zid: &ZenohIdProto, locators: &[Locator]) -> bool {
OlivierHecart marked this conversation as resolved.
Show resolved Hide resolved
let manager = self.manager();
if zid != &manager.zid() {
Expand Down
Loading