Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix peers start conditions bug #1477

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Fix peers start conditions bug #1477

merged 4 commits into from
Sep 27, 2024

Conversation

OlivierHecart
Copy link
Contributor

connect_peers returns false if not connected to avoid wrong start_condititions notif

@OlivierHecart OlivierHecart added the internal Changes not included in the changelog label Sep 26, 2024
oteffahi
oteffahi approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@oteffahi oteffahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug seems fixed.
LGTM.

oteffahi
oteffahi suggested changes Sep 27, 2024
View reviewed changes
zenoh/src/net/runtime/orchestrator.rs Outdated Show resolved Hide resolved
@OlivierHecart OlivierHecart merged commit 941f699 into main Sep 27, 2024
22 of 24 checks passed
@OlivierHecart OlivierHecart deleted the bug/start_conditions branch September 27, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuzzypixelz fuzzypixelz fuzzypixelz left review comments

@oteffahi oteffahi oteffahi approved these changes

Assignees
No one assigned
Labels
internal Changes not included in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OlivierHecart @fuzzypixelz @oteffahi