Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide zenoh_buffers::reader::DidntRead #1447

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Hide zenoh_buffers::reader::DidntRead #1447

merged 1 commit into from
Sep 18, 2024

Conversation

fuzzypixelz
Copy link
Member

n/a.

@fuzzypixelz fuzzypixelz self-assigned this Sep 18, 2024
@fuzzypixelz fuzzypixelz added bug Something isn't working breaking-change Indicates that the issue implies a breaking change (be it at compile time or at runtime) labels Sep 18, 2024
@fuzzypixelz fuzzypixelz requested a review from Mallets September 18, 2024 15:45
@Mallets Mallets merged commit f2c3516 into main Sep 18, 2024
24 of 26 checks passed
@Mallets Mallets deleted the hide-didnt-read-2 branch September 18, 2024 15:51
@Mallets Mallets mentioned this pull request Sep 18, 2024
Closed
Mallets added a commit that referenced this pull request Sep 19, 2024
@Mallets @fuzzypixelz @wyfo
Fix docs (#1430)
4fc61e6 
* Fix docs

* Align naming style of `zenoh_config::defaults` (#1423)

* Put `SourceSn` behind unstable (#1448)

* Notify subscribers on `Notifier<Config>::insert_json5` (#1449)

* Hide `zenoh_buffers::reader::DidntRead` (#1447)

* Apply suggestions from code review

Co-authored-by: Mahmoud Mazouz <[email protected]>

* Add #[doc(hidden)] to internal_config feature

* Update ZBytes docs

* Update ZSerde docs

* Update ZSerde docs

* Fix ZBytesIterator docs

* Fix ZBytesWriter and ZBytesReader docs

* Fix ZBytesSliceIterator docs

* Fix ZenohId docs

* Fix docstring

* Improve FifoChannel and RingChannel docs

---------

Co-authored-by: Mahmoud Mazouz <[email protected]>
Co-authored-by: Joseph Perez <[email protected]>
@fuzzypixelz fuzzypixelz mentioned this pull request Sep 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets approved these changes

Assignees

@fuzzypixelz fuzzypixelz

Labels
breaking-change Indicates that the issue implies a breaking change (be it at compile time or at runtime) bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fuzzypixelz @Mallets