Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unify pub/sub and query/reply modules #1193

Merged
merged 6 commits into from
Jul 3, 2024

Conversation

wyfo
Copy link
Contributor

@wyfo wyfo commented Jun 26, 2024

No description provided.

@wyfo
Copy link
Contributor Author

wyfo commented Jun 26, 2024

@Mallets @kydos @milyin

@wyfo
Copy link
Contributor Author

wyfo commented Jun 26, 2024

I've let the core module as is for now. Maybe we should create a qos module to put QOS related things (Priority and CongestionControl for now, but maybe more later), as they are common to pub/sub and query/reply.

@wyfo
Copy link
Contributor Author

wyfo commented Jun 26, 2024

About Encoding, I'm hesitating to put it in core with Priority and CongestionControl, but it may also be put in bytes module, as this is closely related. I think I prefer this solution now.

@Mallets
Copy link
Member

Mallets commented Jun 27, 2024

@wyfo it would be great if this PR comes with a battery of sister PRs to update all bindings/plugins/backends with the new module organization.

@wyfo
Copy link
Contributor Author

wyfo commented Jun 28, 2024

This is incredibly long to patch all backend/plugins, so I've written a Python script to modify the imports automatically 😅

@wyfo
Copy link
Contributor Author

wyfo commented Jun 28, 2024

@Mallets All the sister PRs have been opened.

@Mallets Mallets merged commit 9fcb61e into eclipse-zenoh:dev/1.0.0 Jul 3, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants